feat: config editor tui

Author: aiomayo

cmd/config.go

@@ -7,6 +7,8 @@ import (
 	"strings"
 
 	"github.com/aiomayo/hdf/internal/config"
+	"github.com/aiomayo/hdf/internal/ui"
+	"github.com/charmbracelet/huh"
 	"github.com/spf13/cobra"
 )
 
@@ -99,7 +101,7 @@ func formatShow(cfg *config.Config) string {
 			if f.Kind == config.StringMap {
 				fmt.Fprintf(&b, "%s\n", formatted)
 			} else {
-				fmt.Fprintf(&b, "%-17s = %-10s  # %s\n", f.Key, formatted, f.Desc)
+				fmt.Fprintf(&b, "%-20s = %-10s  # %s\n", f.DisplayName(), formatted, f.Desc)
 			}
 		}
 	}
@@ -110,19 +112,35 @@ func formatShow(cfg *config.Config) string {
 func newConfigEditCmd() *cobra.Command {
 	return &cobra.Command{
 		Use:   "edit",
-		Short: "Open config in editor",
+		Short: "Open config editor",
 		Args:  cobra.NoArgs,
 		RunE: func(cmd *cobra.Command, args []string) error {
-			editor := os.Getenv("VISUAL")
-			if editor == "" {
-				editor = os.Getenv("EDITOR")
+			cfg, err := config.Load()
+			if err != nil {
+				return err
 			}
+
+			editor := cfg.DefaultEditor
 			if editor == "" {
-				editor = "vi"
+				editor, err = pickEditor()
+				if err != nil {
+					return err
+				}
+				cfg.DefaultEditor = editor
+				if err := config.Save(cfg); err != nil {
+					return err
+				}
 			}
 
-			if _, err := config.Load(); err != nil {
-				return err
+			if editor == "tui" {
+				modified, err := ui.EditConfig(cfg)
+				if err != nil {
+					return err
+				}
+				if modified {
+					return config.Save(cfg)
+				}
+				return nil
 			}
 
 			c := exec.Command(editor, config.Path())
@@ -134,6 +152,38 @@ func newConfigEditCmd() *cobra.Command {
 	}
 }
 
+func pickEditor() (string, error) {
+	f := config.LookupField("default_editor")
+
+	var options []huh.Option[string]
+	for _, opt := range f.Options {
+		if opt == "" {
+			continue
+		}
+		if opt == "tui" {
+			options = append(options, huh.NewOption("Built-in TUI", opt))
+			continue
+		}
+		if _, err := exec.LookPath(opt); err == nil {
+			options = append(options, huh.NewOption(opt, opt))
+		}
+	}
+
+	var choice string
+	form := huh.NewForm(
+		huh.NewGroup(
+			huh.NewSelect[string]().
+				Title("Choose default config editor").
+				Options(options...).
+				Value(&choice),
+		),
+	)
+	if err := form.Run(); err != nil {
+		return "", err
+	}
+	return choice, nil
+}
+
 func newConfigResetCmd() *cobra.Command {
 	return &cobra.Command{
 		Use:   "reset",

go.mod

@@ -4,6 +4,8 @@ go 1.25.0
 
 require (
 	github.com/adrg/xdg v0.5.3
+	github.com/charmbracelet/bubbles v1.0.0
+	github.com/charmbracelet/bubbletea v1.3.10
 	github.com/charmbracelet/huh v0.8.0
 	github.com/charmbracelet/lipgloss v1.1.0
 	github.com/charmbracelet/log v0.4.2
@@ -18,8 +20,6 @@ require (
 	github.com/atotto/clipboard v0.1.4 // indirect
 	github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect
 	github.com/catppuccin/go v0.3.0 // indirect
-	github.com/charmbracelet/bubbles v1.0.0 // indirect
-	github.com/charmbracelet/bubbletea v1.3.10 // indirect
 	github.com/charmbracelet/colorprofile v0.4.2 // indirect
 	github.com/charmbracelet/x/ansi v0.11.6 // indirect
 	github.com/charmbracelet/x/cellbuf v0.0.15 // indirect

internal/config/config.go

@@ -19,6 +19,7 @@ type Config struct {
 	Aliases         map[string]string `mapstructure:"aliases"`
 	DefaultForce    bool              `mapstructure:"default_force"`
 	DefaultVerbose  bool              `mapstructure:"default_verbose"`
+	DefaultEditor   string            `mapstructure:"default_editor"`
 }
 
 func Path() string {
@@ -143,6 +144,13 @@ func ParseValue(f *Field, raw string) (any, error) {
 		return strconv.ParseBool(raw)
 	case String:
 		return raw, nil
+	case Select:
+		for _, opt := range f.Options {
+			if raw == opt {
+				return raw, nil
+			}
+		}
+		return nil, fmt.Errorf("invalid option %q for %s (valid: %s)", raw, f.Key, strings.Join(f.Options, ", "))
 	case Duration:
 		return time.ParseDuration(raw)
 	case StringSlice:
@@ -162,7 +170,7 @@ func FormatValue(f *Field, val any) string {
 	switch f.Kind {
 	case Bool:
 		return strconv.FormatBool(val.(bool))
-	case String:
+	case String, Select:
 		return fmt.Sprintf("%q", val.(string))
 	case Duration:
 		return fmt.Sprintf("%q", val.(time.Duration).String())

internal/config/schema.go

@@ -7,40 +7,62 @@ type Kind int
 const (
 	Bool Kind = iota
 	String
+	Select
 	Duration
 	StringSlice
 	StringMap
 )
 
 type Field struct {
 	Key     string
+	Label   string
 	Group   string
 	Kind    Kind
 	Default any
+	Options []string
 	Desc    string
 }
 
+func (f *Field) DisplayName() string {
+	if f.Label != "" {
+		return f.Label
+	}
+	return f.Key
+}
+
 var Schema = []Field{
 	{
 		Key:     "graceful_timeout",
+		Label:   "Graceful timeout",
 		Kind:    Duration,
 		Default: 5 * time.Second,
 		Desc:    "Graceful shutdown timeout before SIGKILL",
 	},
 	{
 		Key:     "default_force",
+		Label:   "Force kill",
 		Kind:    Bool,
 		Default: false,
-		Desc:    "Always use SIGKILL",
+		Desc:    "Always use SIGKILL instead of SIGTERM",
 	},
 	{
 		Key:     "default_verbose",
+		Label:   "Verbose output",
 		Kind:    Bool,
 		Default: false,
 		Desc:    "Enable verbose output by default",
 	},
+	{
+		Key:     "default_editor",
+		Label:   "Config editor",
+		Kind:    Select,
+		Default: "",
+		Options: []string{"", "tui", "vim", "nvim", "nano", "vi"},
+		Desc:    "Preferred editor for hdf config edit",
+	},
 	{
 		Key:   "protected",
+		Label: "Protected processes",
 		Group: "protected",
 		Kind:  StringSlice,
 		Default: []string{
@@ -51,10 +73,11 @@ var Schema = []Field{
 	},
 	{
 		Key:     "aliases",
+		Label:   "Aliases",
 		Group:   "aliases",
 		Kind:    StringMap,
 		Default: map[string]string{},
-		Desc:    "Query shortcuts",
+		Desc:    "Query shortcuts (name → target)",
 	},
 }