Merge pull request #54 from HaoZeke/fix/52-bound-setup-cache

fix: do not run bound class setup before setup_cache

Author: HaoZeke

CHANGELOG.md

@@ -8,6 +8,16 @@ This project uses [*towncrier*](https://towncrier.readthedocs.io/) and the chang
 
 <!-- towncrier release notes start -->
 
+## [0.3.1](https://github.com/airspeed-velocity/asv_runner/tree/0.3.1) - 15-08-2026
+
+### Bug Fixes
+
+- Class-level ``setup(self)`` no longer runs inside ``do_setup_cache``.
+  Bound methods are not treated as parameter-free module hooks, so
+  ``setup_cache`` runs first again
+  ([#52](https://github.com/airspeed-velocity/asv_runner/issues/52)).
+
+
 ## [0.3.0](https://github.com/airspeed-velocity/asv_runner/tree/0.3.0) - 04-08-2026
 
 ### Bug Fixes

asv_runner/benchmarks/_base.py

@@ -646,11 +646,15 @@ def _build_params(self):
     @staticmethod
     def _is_parameter_free_setup(setup):
         """
-        True if ``setup`` can be called with no positional arguments.
+        True if ``setup`` is a module-level hook callable with no arguments.
 
-        Used so module-level ``setup(*args, **kwargs)`` runs before
-        ``setup_cache`` while class ``setup(self, n)`` waits for ``do_setup``.
+        Module-level ``setup(*args, **kwargs)`` (pandas seed, asv#1592) runs
+        before ``setup_cache``. Bound class ``setup(self)`` and
+        ``setup(self, n)`` wait for ``do_setup``: ``inspect.signature`` omits
+        ``self`` on bound methods, so ``bind()`` alone would mis-fire.
         """
+        if inspect.ismethod(setup):
+            return False
         try:
             inspect.signature(setup).bind()
         except TypeError:

docs/source/conf.py

@@ -7,7 +7,7 @@
 project = "asv_runner"
 copyright = "2023--present, asv Developers"
 author = "asv Developers"
-release = "0.3.0"
+release = "0.3.1"
 
 # -- General configuration ---------------------------------------------------
 # https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration

tbump.toml

@@ -2,7 +2,7 @@
 github_url = "https://github.com/airspeed-velocity/asv_runner/"
 
 [version]
-current = "0.3.0"
+current = "0.3.1"
 
 # Example of a semver regexp.
 # Make sure this matches current_version before

tests/test_cache_skip_setup.py

@@ -104,6 +104,34 @@ def track_fn(cache, n):
         self.assertTrue(Benchmark._is_parameter_free_setup(module_setup))
         self.assertFalse(Benchmark._is_parameter_free_setup(class_setup))
 
+    def test_bound_class_setup_does_not_run_in_do_setup_cache(self):
+        # Discovery builds sources as [func, instance, module], so class
+        # setup(self) is a bound method. signature().bind() then succeeds
+        # because self is already bound (asv_runner#52).
+        order = []
+
+        class Suite:
+            def setup(self):
+                order.append("class_setup")
+                raise AssertionError("class setup must not run in do_setup_cache")
+
+            def setup_cache(self):
+                order.append("setup_cache")
+                return {"ok": True}
+
+            def track_x(self):
+                return 1
+
+        inst = Suite()
+        func = inst.track_x
+        b = TrackBenchmark(
+            "mod.Suite.track_x", func, [func, inst, sys.modules[__name__]]
+        )
+        out = b.do_setup_cache()
+        self.assertEqual(out, {"ok": True})
+        self.assertEqual(order, ["setup_cache"])
+        self.assertFalse(Benchmark._is_parameter_free_setup(inst.setup))
+
     def test_benchmark_decorator_attrs_and_unknown(self):
         @benchmark(pretty_name="Pretty", timeout=12.5, max_time=30.0)
         def track_fn():