Clean up FluentAssertions remnants (#476)

* test: remove FluentAssertions remnants

* ci: retry Windows validation

Author: Aaronontheweb

Directory.Packages.props

@@ -16,7 +16,6 @@
   </ItemGroup>
   <!-- Test dependencies -->
   <ItemGroup>
-    <PackageVersion Include="FluentAssertions" Version="5.10.3" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5">
       <PrivateAssets>all</PrivateAssets>
@@ -31,4 +30,4 @@
   <ItemGroup>
     <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.301" />
   </ItemGroup>
-</Project>
+</Project>

src/Akka.Persistence.MongoDb.Tests/Bug61FixSpec.cs

@@ -105,8 +105,6 @@ public void Bug80_AllEventsByTag_should_Recover_all_messages()
             var eventsByTag = ReadJournal.EventsByTag(typeof(RealMsg).Name)
                 .RunForeach(e => TestActor.Tell(e), Materializer);
 
-            // can't do this because Offset isn't IComparable
-            // ReceiveN(msgCount).Cast<EventEnvelope>().Select(x => x.Offset).Should().BeInAscendingOrder();
             ReceiveN(msgCount);
 
             // should receive more messages after the fact
@@ -208,4 +206,4 @@ class = ""Akka.Persistence.MongoDb.Query.MongoDbReadJournalProvider, Akka.Persis
             return ConfigurationFactory.ParseString(specString);
         }
     }
-}
+}

src/Akka.Persistence.MongoDb.Tests/Hosting/HealthCheckSpec.cs

@@ -77,23 +77,23 @@ public async Task Health_checks_should_be_registered_and_healthy()
             .Where(e => e.Key.Contains("Akka.Persistence", StringComparison.OrdinalIgnoreCase))
             .ToList();
 
-        Assert.Equal(2, (persistenceHealthChecks)?.Count());
+        Assert.Equal(2, persistenceHealthChecks.Count);
 
         // Verify journal health check exists and is healthy
-        var journalHealthCheck = persistenceHealthChecks
-            .FirstOrDefault(e => e.Key.Contains("journal", StringComparison.OrdinalIgnoreCase));
+        var journalHealthCheck = Assert.Single(
+            persistenceHealthChecks,
+            e => e.Key.Contains("journal", StringComparison.OrdinalIgnoreCase));
 
-        Assert.NotNull(journalHealthCheck);
         Assert.Equal(HealthStatus.Healthy, journalHealthCheck.Value.Status);
 
         // Verify snapshot health check exists and is healthy
-        var snapshotHealthCheck = persistenceHealthChecks
-            .FirstOrDefault(e => e.Key.Contains("snapshot", StringComparison.OrdinalIgnoreCase));
+        var snapshotHealthCheck = Assert.Single(
+            persistenceHealthChecks,
+            e => e.Key.Contains("snapshot", StringComparison.OrdinalIgnoreCase));
 
-        Assert.NotNull(snapshotHealthCheck);
         Assert.Equal(HealthStatus.Healthy, snapshotHealthCheck.Value.Status);
 
         // Verify overall health status
         Assert.Equal(HealthStatus.Healthy, healthReport.Status);
     }
-}
+}