Merge pull request #206 from akquinet/issue-205

Log File configurable & log error instead of crashing on missing permissions

Author: rwxd

README.md

@@ -324,10 +324,11 @@ index_html: |
 ### Environment Variables
 
 ```bash
-LOG_LEVEL=DEBUG       # Optional: DEBUG, INFO, WARNING, ERROR (default: DEBUG)
-LOG_FORMAT=json       # Optional: "text" (default) or "json" for structured logging
-LISTEN_HOST=0.0.0.0   # Optional: Host to bind to (default: *)
-LISTEN_PORT=8000      # Optional: Port to listen on (default: 8000)
+LOG_LEVEL=DEBUG            # Optional: DEBUG, INFO, WARNING, ERROR (default: DEBUG)
+LOG_FORMAT=json            # Optional: "text" (default) or "json" for structured logging
+LOG_FILE=/var/log/app.log  # Optional: Log file path (default: "log"), set to "false" to disable file logging
+LISTEN_HOST=0.0.0.0        # Optional: Host to bind to (default: *)
+LISTEN_PORT=8000           # Optional: Port to listen on (default: 8000)
 ```
 
 When `LOG_FORMAT=json` is set, all logs (application and uvicorn access logs) will be output in JSON format.

powerdns_api_proxy/logging.py

@@ -96,14 +96,19 @@ def audit(
 default_stream_handler.setLevel(LOG_LEVEL)
 default_stream_handler.setFormatter(default_formatter)
 
-file_handler = logging.handlers.RotatingFileHandler(
-    filename="log", maxBytes=1000**2 * 100, backupCount=5
-)
-file_handler.setLevel("DEBUG")
-file_handler.setFormatter(default_formatter)
-
 logger: AuditLogger = logging.getLogger("powerdns_api_proxy")  # type: ignore
 logger.addHandler(default_stream_handler)
-logger.addHandler(file_handler)
+
+LOG_FILE = getenv("LOG_FILE", "log")
+if LOG_FILE and LOG_FILE.lower() != "false":
+    try:
+        file_handler = logging.handlers.RotatingFileHandler(
+            filename=LOG_FILE, maxBytes=1000**2 * 100, backupCount=5
+        )
+        file_handler.setLevel(LOG_LEVEL)
+        file_handler.setFormatter(default_formatter)
+        logger.addHandler(file_handler)
+    except OSError as e:
+        logger.error(f"Failed to enable file logging to {LOG_FILE}: {e}")
 
 logger.setLevel("DEBUG")