Merge pull request #1007 from akunzai/chore/clientapp-oxlint-oxfmt

chore(samples): replace ESLint with oxlint and add oxfmt

Author: akunzai

.github/dependabot.yml

@@ -22,7 +22,6 @@ updates:
       typescript:
         patterns:
           - typescript
-          - typescript-eslint
       frontend:
         patterns:
           - '*'

.vscode/extensions.json

@@ -1,6 +1,7 @@
 {
   "recommendations": [
     "mhutchie.git-graph",
-    "ms-dotnettools.csdevkit"
+    "ms-dotnettools.csdevkit",
+    "oxc.oxc-vscode"
   ]
 }

AGENTS.md

@@ -13,7 +13,7 @@ dotnet test --collect:"XPlat Code Coverage" --filter "FullyQualifiedName!~E2E"
 dotnet tool restore && dotnet tool run reportgenerator
 dotnet test --filter "FullyQualifiedName~Cas20ServiceTicketValidatorTests.ValidateAsync"
 cd owin && msbuild -noLogo -verbosity:minimal -restore   # Windows + MSBuild only
-# samples/AspNetCoreReactSample/ClientApp
+# samples/AspNetCoreReactSample/ClientApp (oxlint + oxfmt)
 aube lint && aube build
 ```
 

samples/AspNetCoreReactSample/ClientApp/.oxfmtrc.json

@@ -0,0 +1,7 @@
+{
+  "$schema": "./node_modules/oxfmt/configuration_schema.json",
+  "singleQuote": true,
+  "printWidth": 100,
+  "sortPackageJson": false,
+  "ignorePatterns": ["dist"]
+}

samples/AspNetCoreReactSample/ClientApp/.oxlintrc.json

@@ -0,0 +1,21 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "plugins": ["typescript", "react", "import", "jsx-a11y", "unicorn", "oxc"],
+  "categories": {
+    "correctness": "error",
+    "suspicious": "warn"
+  },
+  "env": {
+    "browser": true
+  },
+  "ignorePatterns": ["dist"],
+  "rules": {
+    "react/react-in-jsx-scope": "off",
+    "import/no-unassigned-import": [
+      "warn",
+      {
+        "allow": ["**/*.css"]
+      }
+    ]
+  }
+}

samples/AspNetCoreReactSample/ClientApp/README.md

@@ -16,4 +16,10 @@ aube start
 
 # build the project in production mode. The build artifacts will be stored in the `dist/` directory
 aube build
+
+# lint (oxlint) and check formatting (oxfmt)
+aube lint
+
+# write oxfmt changes
+aube format
 ```

samples/AspNetCoreReactSample/ClientApp/aspnetcore-https.js

@@ -17,7 +17,7 @@ const certificateName = certificateArg
 
 if (!certificateName) {
   console.error(
-    'Invalid certificate name. Run this script in the context of an npm/yarn script or pass --name=<<app>> explicitly.'
+    'Invalid certificate name. Run this script in the context of an npm/yarn script or pass --name=<<app>> explicitly.',
   );
   process.exit(-1);
 }
@@ -32,15 +32,7 @@ if (!existsSync(baseFolder)) {
 if (!existsSync(certFilePath) || !existsSync(keyFilePath)) {
   spawn(
     'dotnet',
-    [
-      'dev-certs',
-      'https',
-      '--export-path',
-      certFilePath,
-      '--format',
-      'Pem',
-      '--no-password',
-    ],
-    { stdio: 'inherit' }
+    ['dev-certs', 'https', '--export-path', certFilePath, '--format', 'Pem', '--no-password'],
+    { stdio: 'inherit' },
   ).on('exit', (code) => process.exit(code));
 }

samples/AspNetCoreReactSample/ClientApp/aspnetcore-react.js

@@ -12,13 +12,11 @@ const baseFolder =
 const certificateArg = process.argv
   .map((arg) => arg.match(/--name=(?<value>.+)/i))
   .filter(Boolean)[0];
-const certificateName = certificateArg
-  ? certificateArg.groups.value
-  : process.env.npm_package_name;
+const certificateName = certificateArg ? certificateArg.groups.value : process.env.npm_package_name;
 
 if (!certificateName) {
   console.error(
-    'Invalid certificate name. Run this script in the context of an npm/yarn script or pass --name=<<app>> explicitly.'
+    'Invalid certificate name. Run this script in the context of an npm/yarn script or pass --name=<<app>> explicitly.',
   );
   process.exit(-1);
 }
@@ -30,7 +28,7 @@ if (!existsSync('.env.development.local')) {
   writeFileSync(
     '.env.development.local',
     `SSL_CRT_FILE=${certFilePath}
-SSL_KEY_FILE=${keyFilePath}`
+SSL_KEY_FILE=${keyFilePath}`,
   );
 } else {
   let lines = readFileSync('.env.development.local').toString().split('\n');
@@ -46,15 +44,9 @@ SSL_KEY_FILE=${keyFilePath}`
     }
   }
   if (!hasCert) {
-    appendFileSync(
-      '.env.development.local',
-      `\nSSL_CRT_FILE=${certFilePath}`
-    );
+    appendFileSync('.env.development.local', `\nSSL_CRT_FILE=${certFilePath}`);
   }
   if (!hasCertKey) {
-    appendFileSync(
-      '.env.development.local',
-      `\nSSL_KEY_FILE=${keyFilePath}`
-    );
+    appendFileSync('.env.development.local', `\nSSL_KEY_FILE=${keyFilePath}`);
   }
 }

samples/AspNetCoreReactSample/ClientApp/eslint.config.js

@@ -1,11 +1,8 @@
-<!DOCTYPE html>
+<!doctype html>
 <html lang="en">
   <head>
     <meta charset="utf-8" />
-    <meta
-      name="viewport"
-      content="width=device-width, initial-scale=1, shrink-to-fit=no"
-    />
+    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
     <meta name="theme-color" content="#000000" />
     <base href="/" />
     <!--