Fix saveCounterOrder doing nothing because of Kotlin footguns

albertvaka · albertvaka · commit 529a168b4384 · 2025-06-09T23:14:37.000+02:00
diff --git a/app/src/main/java/org/kde/bettercounter/ui/main/MainActivityViewModel.kt b/app/src/main/java/org/kde/bettercounter/ui/main/MainActivityViewModel.kt
@@ -211,7 +211,7 @@ class MainActivityViewModel(val application: Application) {
 
     fun getCounterList() = counters
 
-    fun saveCounterOrder(value: List<String>) = {
+    fun saveCounterOrder(value: List<String>) {
         counters = value
         repo.setCounterList(value)
     }

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ class MainActivityViewModel(val application: Application) {`
`211`	`211`
`212`	`212`	`fun getCounterList() = counters`
`213`	`213`
`214`		`- fun saveCounterOrder(value: List<String>) = {`
	`214`	`+ fun saveCounterOrder(value: List<String>) {`
`215`	`215`	`counters = value`
`216`	`216`	`repo.setCounterList(value)`
`217`	`217`	`}`