fix: only run versions when requested (#9)

kai687 · web-flow · commit 31133fe0e2a3 · 2025-07-01T19:59:21.000+02:00
Only generate the version file when the `-v` option is not an empty
string.
diff --git a/pkg/cmd/generate/sla/sla.go b/pkg/cmd/generate/sla/sla.go
@@ -104,17 +104,14 @@ func runCommand(opts *Options) {
 		log.Fatalf("error: %v", err)
 	}
 
-	var versionsOutput io.Writer
-	if opts.VersionsFile == "" {
-		versionsOutput = os.Stdout
-	} else {
-		versionsOutput, err = os.Create(opts.VersionsFile)
+	if opts.VersionsFile != "" {
+		versionsOutput, err := os.Create(opts.VersionsFile)
 		if err != nil {
 			log.Fatalf("error: %v", err)
 		}
-	}
 
-	renderVersionsFile(versionsOutput, sorted)
+		renderVersionsFile(versionsOutput, sorted)
+	}
 }
 
 // parseVersions reads a JSON file and parses it into a Clients struct.

Original file line number	Diff line number	Diff line change
`@@ -104,17 +104,14 @@ func runCommand(opts *Options) {`
`104`	`104`	`log.Fatalf("error: %v", err)`
`105`	`105`	`}`
`106`	`106`
`107`		`- var versionsOutput io.Writer`
`108`		`- if opts.VersionsFile == "" {`
`109`		`- versionsOutput = os.Stdout`
`110`		`- } else {`
`111`		`- versionsOutput, err = os.Create(opts.VersionsFile)`
	`107`	`+ if opts.VersionsFile != "" {`
	`108`	`+ versionsOutput, err := os.Create(opts.VersionsFile)`
`112`	`109`	`if err != nil {`
`113`	`110`	`log.Fatalf("error: %v", err)`
`114`	`111`	`}`
`115`		`- }`
`116`	`112`
`117`		`- renderVersionsFile(versionsOutput, sorted)`
	`113`	`+ renderVersionsFile(versionsOutput, sorted)`
	`114`	`+ }`
`118`	`115`	`}`
`119`	`116`
`120`	`117`	`// parseVersions reads a JSON file and parses it into a Clients struct.`