"Try searching for" no-results suggestions never render in v4 (searchSuggestions built as an object, consumed as an array)

[LukasTy]

Description

The "Try searching for" suggestions on the no-results screen never render in v4 (they did in v3). state.context.searchSuggestions is written as an object but consumed as an array, so NoResultsScreen's searchSuggestions.length > 0 guard is always false and the list is silently skipped.

Producer -- DocSearchModal.tsx (4.6.3 and main):

searchSuggestions: { ...(sourcesState.context.searchSuggestions ?? []), ...Object.keys(sources) }
// object-literal spread -> { 0: "...", 1: "..." }, not an array

Consumer -- NoResultsScreen.tsx (4.6.3 and main): typed string[], uses .length and .slice. v3 stored a plain array (searchSuggestions: Object.keys(sources)), which is why it worked there.

Fix: array spread instead of object spread (keeps the accumulate-across-searches intent):

searchSuggestions: [ ...(sourcesState.context.searchSuggestions ?? []), ...Object.keys(sources) ]

Steps to reproduce

1. Open the DocSearch modal.
2. Type a query that returns results (this populates the suggestions with the result group lvl0s).
3. Type a query that returns no results.
4. The "Try searching for:" list is missing (it appears in v3).

Expected behavior

The no-results screen shows the "Try searching for:" suggestions, as it does in v3.

Environment

• OS: any (code-path bug, not environment specific)
• Browser: any
• DocSearch version: 4.6.3 (same code on main)

[Fenz-art]

I investigated this issue and confirmed that the problem is caused by a mismatch between the data shape produced for searchSuggestions and the shape expected by the no-results UI.

DocSearchModal was updating searchSuggestions using object spread, which converted the array into an object-like structure:

{
0: "Suggestion A",
1: "Suggestion B"
}

However, NoResultsScreen expects searchSuggestions to remain an array and uses array operations such as .length and .slice().

Because the value was no longer an array, the no-results suggestions check failed and the "Try searching for" suggestions were not rendered.

I have a fix ready that changes the update logic to use array spread, preserving the expected array shape. I am also adding a regression test covering the flow where suggestions from a previous successful search are displayed after a query returns no results.

[Fenz-art]

Final regression verification completed.

I verified the regression test against both the previous behavior and the fix:

Before the fix:

• The regression test failed as expected.
• The no-results screen could not find the "Try searching for" suggestions.

After the fix:

• The same regression test passed.
• The previous-search → no-results flow correctly renders the suggestions.

This confirms the test covers the user-facing regression rather than only checking the internal state shape.