Skip to content

Commit 0119142

Browse files
rafaelfs98brianchandotcom
authored andcommitted
LPS-184466 Disable autofill buttons
1 parent 3301e08 commit 0119142

2 files changed

Lines changed: 42 additions & 2 deletions

File tree

  • modules/apps/site-initializer/site-initializer-testray/site-initializer-testray

modules/apps/site-initializer/site-initializer-testray/site-initializer-testray/extra/remote-app/src/components/CompareRunsPopover/index.tsx

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import ClayLayout from '@clayui/layout';
1818
import classNames from 'classnames';
1919
import {useEffect, useRef} from 'react';
2020
import {useNavigate} from 'react-router-dom';
21+
import {useObjectPermission} from '~/hooks/data/useObjectPermission';
2122

2223
import useRuns from '../../hooks/useRuns';
2324
import i18n from '../../i18n';
@@ -43,6 +44,11 @@ const CompareRunsPopover: React.FC<CompareRunsPopoverProps> = ({
4344
const {compareRuns, setRunA, setRunB} = useRuns();
4445
const disableButtonA = !(compareRuns?.runId || compareRuns?.runA);
4546
const disableButtonB = !(compareRuns?.runId || compareRuns?.runB);
47+
const caseResultPermission = useObjectPermission('/caseresults');
48+
const disbleButtonAutofillRuns = caseResultPermission.canCreate;
49+
const buildsPermission = useObjectPermission('/builds');
50+
const disbleButtonAutofillBuilds = buildsPermission.canCreate;
51+
4652
const validateCompareButtons = !(compareRuns?.runA && compareRuns?.runB);
4753
const navigate = useNavigate();
4854

@@ -174,15 +180,21 @@ const CompareRunsPopover: React.FC<CompareRunsPopoverProps> = ({
174180
</ClayButton>
175181

176182
<ClayButton
177-
disabled={validateCompareButtons}
183+
disabled={
184+
validateCompareButtons ||
185+
!disbleButtonAutofillRuns
186+
}
178187
displayType="primary"
179188
onClick={() => onAutoFill('Run')}
180189
>
181190
{i18n.sub('auto-fill-x', 'runs')}
182191
</ClayButton>
183192

184193
<ClayButton
185-
disabled={validateCompareButtons}
194+
disabled={
195+
validateCompareButtons ||
196+
!disbleButtonAutofillBuilds
197+
}
186198
displayType="primary"
187199
onClick={() => onAutoFill('Build')}
188200
>

modules/apps/site-initializer/site-initializer-testray/site-initializer-testray/src/main/resources/site-initializer/resource-permissions.json

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -744,6 +744,34 @@
744744
"roleName": "Testray Analyst",
745745
"scope": 1
746746
},
747+
{
748+
"actionIds": [
749+
"ADD_DISPATCH_TRIGGER"
750+
],
751+
"primKey": "0",
752+
"resourceName": "com.liferay.dispatch",
753+
"roleName": "Testray Analyst",
754+
"scope": 1
755+
},
756+
{
757+
"actionIds": [
758+
"UPDATE",
759+
"VIEW"
760+
],
761+
"primKey": "0",
762+
"resourceName": "com.liferay.dispatch.model.DispatchTrigger",
763+
"roleName": "Testray Analyst",
764+
"scope": 1
765+
},
766+
{
767+
"actionIds": [
768+
"ADD_OBJECT_ENTRY"
769+
],
770+
"primKey": "0",
771+
"resourceName": "com.liferay.object#[$OBJECT_DEFINITION_ID:TestrayDispatchTrigger$]",
772+
"roleName": "Testray Analyst",
773+
"scope": 1
774+
},
747775
{
748776
"actionIds": [
749777
"DELETE",

0 commit comments

Comments
 (0)