PTR-4515 Avoid unnecessary evaluations

Author: aline-doleron

modules/apps/data-engine/data-engine-js-components-web/src/main/resources/META-INF/resources/js/core/components/PageRenderer/Layout.es.js

@@ -101,6 +101,7 @@ export function Layout({components, editable, itemPath, rows, viewMode}) {
 												),
 												properties,
 												submitButtonId,
+												viewMode,
 											})
 										)
 									}

modules/apps/data-engine/data-engine-js-components-web/src/main/resources/META-INF/resources/js/core/hooks/useEvaluate.es.js

@@ -14,7 +14,7 @@ import {useFormState} from './useForm.es';
  * the `evaluate` function.
  */
 export function useEvaluate(thunk) {
-	const {groupId, portletNamespace, viewMode} = useConfig();
+	const {groupId, portletNamespace} = useConfig();
 	const {
 		defaultLanguageId,
 		editingLanguageId,
@@ -35,7 +35,6 @@ export function useEvaluate(thunk) {
 				portletNamespace,
 				rules,
 				title,
-				viewMode,
 				...args,
 			}),
 		[
@@ -48,7 +47,6 @@ export function useEvaluate(thunk) {
 			rules,
 			thunk,
 			title,
-			viewMode,
 		]
 	);
 }

modules/apps/data-engine/data-engine-js-components-web/src/main/resources/META-INF/resources/js/core/thunks/fieldChange.es.js

@@ -10,6 +10,18 @@ import {disableSubmitButton} from '../utils/submitButtonController.es';
 
 let REVALIDATE_UPDATES = [];
 
+const requireUpdatePageFieldNames = [
+	'autocomplete',
+	'requireConfirmation',
+	'required',
+	'validation',
+	'inputMask',
+];
+
+const needsPageUpdate = (fieldName) => {
+	return requireUpdatePageFieldNames.includes(fieldName);
+};
+
 const getEditedPages = ({
 	editingLanguageId,
 	key = 'value',
@@ -83,7 +95,7 @@ export default function fieldChange({
 
 		dispatch({payload: editedPages, type: EVENT_TYPES.PAGE.UPDATE});
 
-		if (evaluable) {
+		if (evaluable && (viewMode || needsPageUpdate(fieldName))) {
 			try {
 				disableSubmitButton(submitButtonId);
 

modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-field-type/src/main/resources/META-INF/resources/Text/Text.es.js

@@ -279,7 +279,7 @@ const Autocomplete = ({
 	const itemListRef = useRef(null);
 
 	const escapeChars = (string) =>
-		string.replace(/[.*+\-?^${}()|[\]\\]/g, '\\$&');
+		string?.replace(/[.*+\-?^${}()|[\]\\]/g, '\\$&');
 
 	const filteredItems = options.filter(
 		(item) => item && item.match(escapeChars(value))