Skip to content

[Phase 1.4] Implement tool execution subsystem #519

Description

@anchapin

Phase: Phase 1 - Foundation
Priority: high
Component: orchestrator
Effort: medium

Description

Create tool execution module that spawns subprocesses for MCP tools. Implement command validation to prevent shell injection. Use subprocess list invocation (no shell). Add tests.

Acceptance Criteria

  • Create tool execution module in orchestrator/src/
  • Implement subprocess spawning with list invocation
  • Add command validation to prevent shell injection
  • Whitelist known-safe commands (npx, python, node, cargo)
  • Add timeout handling
  • Add comprehensive tests
  • Target 75% test coverage

Dependencies

Notes

Security is critical here - never use shell=True. Always use subprocess with command as list to prevent injection attacks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions