fix global python dependencies

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

Author: openhabian

functions/grott-install.bash

@@ -35,10 +35,9 @@ install_grott() {
 
     echo "$(timestamp) [openHABian] Installing Grott Proxy with extension URL: $EXT_URL "
 
-    # Update system and install dependencies
+    # Update system and install dependencies. NOTE: paho-mqtt is a required dependency (even if disabled)
     sudo apt update
-    sudo apt install -y python3 python3-pip
-    sudo pip3 install paho-mqtt requests # paho-mqtt is a required dependency (even if disabled)
+    sudo apt install -y python3 python3-pip python3-paho-mqtt python3-requests
 
     # Prepare installation directory
     sudo -u "$USERNAME" mkdir -p -m 755 "$INSTALL_DIR"
@@ -130,6 +129,8 @@ download_grott_files() {
   local GROTT_EXT_PY_FILE="grottext.py"
   local file url
 
+  echo "Installing files to $INSTALL_DIR "
+
   # Download Grott main program Python files
   for file in "${GROTT_PY_FILES[@]}"; do
     url="${GROTT_FILE_URL}/${file}"

functions/grott-install.bats

@@ -26,15 +26,7 @@ teardown_file() {
 
   ## Check grott service is running
   echo -e "# ${COL_CYAN}$(timestamp) [openHABian] Checking if Grott Proxy service is running...${COL_DEF}" >&3
-  run systemctl status grott
-  echo "Grott service status: $status"
-  echo "Grott service status: $output"
-
   run systemctl is-active --quiet grott
-  run systemctl is-active grott
-  echo "Grott service is-active returned: $status"
-  [ "$status" -eq 0 ] || { echo "Grott Proxy service failed to start"; systemctl status grott; exit 1; }
-
   if [ "$status" -ne 0 ]; then echo "$output" >&3; fi
   [ "$status" -eq 0 ]
   echo -e "# ${COL_GREEN}$(timestamp) [openHABian] Grott Proxy service is running.${COL_DEF}" >&3

includes/grott.ini

@@ -19,20 +19,20 @@ ip = default
 port = 5279
 
 # To blocks commands from outside (to channge inverter and shine devices settings) specify blockcmd = True,
-# Specify noipf = True if you still want be able to set the destination ip addres from growatt server (advice 
+# Specify noipf = True if you still want be able to set the destination ip addres from growatt server (advice
 # only to use this for a short time)
-#blockcmd = True 
+#blockcmd = True
 #noipf = True
 
-# Time = auto/server parameter enable/disable date/time retrieval from data record (server), default is 
-# auto: grott decides which time is used (data record if valid otherwise Server) 
+# Time = auto/server parameter enable/disable date/time retrieval from data record (server), default is
+# auto: grott decides which time is used (data record if valid otherwise Server)
 # If time = server Grott server time is alwas used
-#time = auto 
+#time = auto
 
 # Sendbuf = True / False parameter to enable  / disable sending historical (buffered) data. Default is sendbuf = True.
-#sendbuf = True 
+#sendbuf = True
 
-# Compat is True and valoffset needs to be set if offset / growatt protocol has been changed. 
+# Compat is True and valoffset needs to be set if offset / growatt protocol has been changed.
 compat = False
 #valueoffset = 6
 
@@ -45,14 +45,14 @@ invtype = sph
 # >2.1.0 if compat = false!)
 #decrypt = True
 
-[Growatt] 
+[Growatt]
 # Server name/IP address and port of Growatt server
 # specify only if the IP address of server.growatt.com is changed
 # The address as of Nov 2022 is 47.91.67.66
 
 ip = server.growatt.com
 #ip = 47.91.67.66
-#port = 5279                                                        
+#port = 5279
 
 [MQTT]
 # Mqtt parameters definitions
@@ -70,7 +70,7 @@ nomqtt = True
 # PVOutput parameters definitions
 
 pvoutput = False
-#apikey = yourapikey 
+#apikey = yourapikey
 # Data upload limit (in minutes)
 #pvuplimit = 5
 # Use this if you have one inverter
@@ -98,9 +98,9 @@ pvoutput = False
 #password = growatt2020
 #token  = "influx_token"
 #org  = "grottorg"
-#bucket = "grottdb" 
+#bucket = "grottdb"
 
-[extension] 
+[extension]
 # grott extension parameters definitions
 extension = True
 extname = grottext