Updated lock check to include add_reference method

Author: ankane

lib/strong_migrations/checks.rb

@@ -191,6 +191,9 @@ def check_add_reference(method, *args)
 
       check_algorithm_option("add_reference", *args, **options)
 
+      # not necessarily dangerous, but not necessary
+      check_lock_option("add_reference", *args, **options)
+
       if (mysql? || mariadb?) && !new_table?(table)
         index_value = options[:index]
         copy_set = index_value.is_a?(Hash) && index_value[:algorithm] == :copy

test/add_reference_test.rb

@@ -105,6 +105,16 @@ def test_algorithm_instant
     assert_safe AddReferenceAlgorithmInstant
   end
 
+  def test_lock_shared
+    skip unless lock_option?
+    assert_unsafe AddReferenceLockShared
+  end
+
+  def test_lock_none
+    skip unless lock_option?
+    assert_safe AddReferenceLockNone
+  end
+
   def test_index_algorithm_copy
     skip unless mysql? || mariadb?
     assert_unsafe AddReferenceIndexAlgorithmCopy

test/migrations/add_reference.rb

@@ -84,6 +84,18 @@ def change
   end
 end
 
+class AddReferenceLockShared < TestMigration
+  def change
+    add_reference :users, :device, lock: :shared
+  end
+end
+
+class AddReferenceLockNone < TestMigration
+  def change
+    add_reference :users, :device, lock: :none
+  end
+end
+
 class AddReferenceIndexAlgorithmCopy < TestMigration
   def change
     add_reference :users, :device, index: {algorithm: :copy}