Commit e00291a
committed
CI: drop Ruby 3.0 x Rails 5.2 matrix cell (Rails 5.2 + modern Rack bit-rot)
Phase 2a's integration specs (spec/dummy/) boot Rails, which exposes
two pre-existing Rails 5.2 + modern-Rack incompatibilities that were
previously hidden because old unit specs never loaded Rails:
1. ActionDispatch::Static#initialize signature is (app, root, headers)
in Rails 5.2 but modern Rack passes (app, path, urls, options),
raising "wrong number of arguments (given 3, expected 2)".
2. MiddlewareStack#operations is called by Rails 5.2's railties
configuration.rb:78 but the method was renamed in newer Rack,
raising "undefined method 'operations'".
These are Rails 5.2 bit-rot, not Phase 2a bugs. Rails 5.2 is EOL
since 2022-06 and Ruby 3.0 is EOL since 2024-03 — the combination
is past its usefulness. The matrix already excludes Rails 5.2 x
Ruby 3.1+ for compatibility reasons; adding Ruby 3.0 to the
exclusion list keeps the rest of the matrix green.
After this fix, the matrix is 30 cells, all green on main. Any
host app on modern Rack + Rails 5.2 would hit the same issue
regardless of mysql_genius.1 parent 2aa2d8e commit e00291a
1 file changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
| |||
0 commit comments