fix: address code review feedback

- Fix usage message in extract-results.js and compare-results.js
- Add file existence checks in benchmark.ts to validate example files
- Improve error handling in workflow using continue-on-error
- Make benchmark failures more visible while still allowing comparison

Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>

Author: Copilot

.github/workflows/benchmark.yml

@@ -33,15 +33,17 @@ jobs:
 
       - name: Run PR benchmarks
         id: pr-benchmark
+        continue-on-error: true
         run: |
           echo "Running benchmarks on PR branch..."
           yarn benchmark > pr-benchmark.txt 2>&1
           EXIT_CODE=$?
           cat pr-benchmark.txt
-          if [ $EXIT_CODE -ne 0 ]; then
-            echo "⚠️ Benchmark run failed with exit code $EXIT_CODE"
-          fi
-          exit 0
+          exit $EXIT_CODE
+
+      - name: Check PR benchmark status
+        if: steps.pr-benchmark.outcome == 'failure'
+        run: echo "⚠️ PR benchmarks failed - will attempt to extract partial results"
 
       - name: Extract PR results
         id: pr-results
@@ -60,15 +62,17 @@ jobs:
 
       - name: Run base benchmarks
         id: base-benchmark
+        continue-on-error: true
         run: |
           echo "Running benchmarks on base branch..."
           yarn benchmark > base-benchmark.txt 2>&1
           EXIT_CODE=$?
           cat base-benchmark.txt
-          if [ $EXIT_CODE -ne 0 ]; then
-            echo "⚠️ Benchmark run failed with exit code $EXIT_CODE"
-          fi
-          exit 0
+          exit $EXIT_CODE
+
+      - name: Check base benchmark status
+        if: steps.base-benchmark.outcome == 'failure'
+        run: echo "⚠️ Base benchmarks failed - will attempt to extract partial results"
 
       - name: Extract base results
         id: base-results

benchmark/benchmark.ts

@@ -13,6 +13,8 @@
 // limitations under the License.
 
 import Benchmark from 'benchmark';
+import * as fs from 'fs';
+import * as path from 'path';
 
 // Use CommonJS require to import from built library
 // eslint-disable-next-line @typescript-eslint/no-var-requires
@@ -28,6 +30,31 @@ interface BenchmarkResult {
 
 const results: BenchmarkResult[] = [];
 
+// Verify required example files exist
+function checkExampleFiles(): void {
+  const requiredFiles = [
+    'examples/rbac_model.conf',
+    'examples/rbac_policy.csv',
+    'examples/abac_model.conf',
+    'examples/basic_model.conf',
+    'examples/basic_policy.csv',
+  ];
+
+  const missingFiles: string[] = [];
+  for (const file of requiredFiles) {
+    if (!fs.existsSync(path.join(process.cwd(), file))) {
+      missingFiles.push(file);
+    }
+  }
+
+  if (missingFiles.length > 0) {
+    console.error('Error: Required example files not found:');
+    missingFiles.forEach((file) => console.error(`  - ${file}`));
+    console.error('\nPlease ensure you are running this from the repository root directory.');
+    process.exit(1);
+  }
+}
+
 async function setupEnforcers(): Promise<{
   rbacEnforcer: any;
   abacEnforcer: any;
@@ -63,6 +90,9 @@ function createSuite(name: string): Benchmark.Suite {
 }
 
 async function runBenchmarks(): Promise<void> {
+  // Check that all required files exist
+  checkExampleFiles();
+
   console.log('Setting up enforcers...');
   const { rbacEnforcer, abacEnforcer, basicEnforcer } = await setupEnforcers();
 

benchmark/compare-results.js

@@ -5,7 +5,7 @@
 const fs = require('fs');
 
 if (process.argv.length < 4) {
-  console.error('Usage: compare-results.js <base-results.json> <pr-results.json>');
+  console.error('Usage: node compare-results.js <base-results.json> <pr-results.json>');
   process.exit(1);
 }
 

benchmark/extract-results.js

@@ -5,7 +5,7 @@
 const fs = require('fs');
 
 if (process.argv.length < 4) {
-  console.error('Usage: extract-benchmark-results.js <input-file> <output-file>');
+  console.error('Usage: node extract-results.js <input-file> <output-file>');
   process.exit(1);
 }