reject an empty option name in getMatchingOptions

An empty name after hyphen stripping matched every long option, so the token "--=value" bound the value to a long option that was never named.

Author: farkhalit

src/main/java/org/apache/commons/cli/Options.java

@@ -219,6 +219,10 @@ public Options addRequiredOption(final String opt, final String longOpt, final b
     public List<String> getMatchingOptions(final String opt) {
         final String clean = Util.stripLeadingHyphens(opt);
         final List<String> matchingOpts = new ArrayList<>();
+        // an empty name is not a partial name, it would match every long option
+        if (Util.isEmpty(clean)) {
+            return matchingOpts;
+        }
         // for a perfect match return the single option only
         if (longOpts.containsKey(clean)) {
             return Collections.singletonList(clean);

src/test/java/org/apache/commons/cli/OptionsTest.java

@@ -182,6 +182,19 @@ void testGetMatchingOpts() {
         assertToStrings(options.getOption("verbose"));
     }
 
+    @Test
+    void testGetMatchingOptsEmptyName() throws Exception {
+        final Options options = new Options();
+        options.addOption(Option.builder("c").longOpt("config-file").hasArg().get());
+        assertTrue(options.getMatchingOptions("").isEmpty());
+        assertTrue(options.getMatchingOptions("-").isEmpty());
+        assertTrue(options.getMatchingOptions("--").isEmpty());
+        // "--=value" names no option, so it must not bind a value to config-file
+        for (final CommandLineParser parser : new CommandLineParser[] { new DefaultParser(), new PosixParser() }) {
+            assertThrows(UnrecognizedOptionException.class, () -> parser.parse(options, new String[] { "--=/etc/shadow" }));
+        }
+    }
+
     @Test
     void testGetOptionsGroups() {
         final Options options = new Options();