Move from husky to pre-commit

Author: Jason Young

.husky/pre-commit

@@ -0,0 +1,30 @@
+repos:
+  - repo: local
+    hooks:
+      - id: userale-format
+        name: Prettier Format Check (userale)
+        entry: bash -c 'cd products/userale && pnpm run format'
+        language: system
+        pass_filenames: false
+        files: ^products/userale/
+
+      - id: userale-lint
+        name: ESLint Check (userale)
+        entry: bash -c 'cd products/userale && pnpm run lint'
+        language: system
+        pass_filenames: false
+        files: ^products/userale/
+
+      - id: userale-build
+        name: Build Check (userale)
+        entry: bash -c 'cd products/userale && pnpm run build'
+        language: system
+        pass_filenames: false
+        files: ^products/userale/
+
+      - id: userale-test
+        name: Tests (userale)
+        entry: bash -c 'cd products/userale && pnpm run test'
+        language: system
+        pass_filenames: false
+        files: ^products/userale/

.pre-commit-config.yaml

@@ -0,0 +1,50 @@
+import js from '@eslint/js';
+import tseslint from 'typescript-eslint';
+import pluginJest from 'eslint-plugin-jest';
+
+export default [
+    js.configs.recommended,
+    ...tseslint.configs.recommended,
+    {
+        files: ['**/*.{ts,tsx,js,jsx}'],
+        languageOptions: {
+            parser: tseslint.parser,
+            sourceType: 'module',
+            globals: {
+                window: 'readonly',
+                document: 'readonly',
+                navigator: 'readonly',
+                console: 'readonly',
+            },
+        },
+        plugins: {
+            '@typescript-eslint': tseslint.plugin,
+        },
+        rules: {
+            'no-cond-assign': 'warn',
+            'no-constant-condition': 'warn',
+            'no-unused-vars': 'warn',
+            '@typescript-eslint/no-unused-vars': 'warn',
+            '@typescript-eslint/no-explicit-any': 'warn',
+        },
+    },
+    {
+        files: ['test/**/*.{ts,tsx,js,jsx}'],
+        plugins: {
+            jest: pluginJest,
+        },
+        languageOptions: {
+            globals: {
+                describe: 'readonly',
+                test: 'readonly',
+                expect: 'readonly',
+                beforeEach: 'readonly',
+                afterEach: 'readonly',
+                jest: 'readonly',
+            },
+        },
+        rules: {
+        // Optional Jest-specific rules
+        },
+    },
+];

eslint.config.js

@@ -3,21 +3,30 @@
   "private": true,
   "version": "1.0.0",
   "scripts": {
+    "format": "prettier --ignore-path .gitignore --write 'packages/**/{src,test}/**/*.{ts,js,tsx,jsx}'",
+    "lint": "eslint 'packages/**/src/**/*.{ts,js,tsx,jsx}' --fix",
     "build": "pnpm -r run build",
     "test": "playwright test -c ./test/playwright.config.ts && pnpm -r test",
     "pretest": "npx playwright install",
     "example:run": "node example/server/server.js",
     "example:watch": "nodemon -w ./example/server example/server/server.js"
   },
   "devDependencies": {
+    "@eslint/js": "^9.29.0",
+    "@ianvs/prettier-plugin-sort-imports": "4.1.1",
     "@playwright/test": "^1.52.0",
     "@types/node": "^22.15.30",
     "body-parser": "^1.20.2",
+    "eslint": "9.29.0",
+    "eslint-plugin-jest": "^29.0.1",
     "express": "^4.18.2",
     "flagon-userale": "workspace:flagon-userale",
     "jsonschema": "^1.4.1",
-    "pnpm": "^10.0.0",
     "nodemon": "^3.0.2",
+    "pnpm": "^10.0.0",
+    "prettier": "3.6.0",
+    "typescript": "^5.8.3",
+    "typescript-eslint": "^7.8.0",
     "ws": "^8.18.0"
   }
 }

products/userale/eslint.config.js

@@ -1,35 +1,41 @@
-import { getStoredOptions } from "~/utils/storage";
-import { setOptions } from "./messages/config_change";
-import { sendToContent } from "~utils/messaging";
+import { getStoredOptions } from "~/utils/storage"
+import { sendToContent } from "~utils/messaging"
+
+import { setOptions } from "./messages/config_change"
 
 // Top level await is not supported so immediately execute this async function to set options from storage
-(async () => {
-    const options = await getStoredOptions();
-    setOptions(options);
-})();
+
+;(async () => {
+  const options = await getStoredOptions()
+  setOptions(options)
+})()
 
 // Takes a tabId and event data, gets the tab, and sends it
 function sendTabEvent(tabId: number, data: Record<string, any>, type: string) {
   chrome.tabs.get(tabId, (tab) => {
     if (!tab) return
     sendTabEventFromTab(tab, data, type)
-  });
+  })
 }
 
 // Sends an event directly from a tab object
-function sendTabEventFromTab(tab: chrome.tabs.Tab, data: Record<string, any>, type: string) {
+function sendTabEventFromTab(
+  tab: chrome.tabs.Tab,
+  data: Record<string, any>,
+  type: string
+) {
   const payload = {
     type,
     tab,
     data
-  };
+  }
 
   sendToContent(tab.id!, { type: "tab-event", payload }).catch((err) =>
     console.warn(`Failed to send ${type} to tab ${tab.id}:`, err.message)
-  );
+  )
 }
 
-// Tab event handlers 
+// Tab event handlers
 // https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs
 
 // TODO handle events that are sent when the tab isn't active.
@@ -39,46 +45,46 @@ function sendTabEventFromTab(tab: chrome.tabs.Tab, data: Record<string, any>, ty
 
 chrome.tabs.onActivated.addListener((activeInfo) =>
   sendTabEvent(activeInfo.tabId, activeInfo, "tabs.onActivated")
-);
+)
 
 chrome.tabs.onAttached.addListener((tabId, attachInfo) =>
   sendTabEvent(tabId, attachInfo, "tabs.onAttached")
-);
+)
 
 chrome.tabs.onCreated.addListener((tab) =>
   sendTabEventFromTab(tab, {}, "tabs.onCreated")
-);
+)
 
 chrome.tabs.onDetached.addListener((tabId, detachInfo) =>
   sendTabEvent(tabId, detachInfo, "tabs.onDetached")
-);
+)
 
 chrome.tabs.onMoved.addListener((tabId, moveInfo) =>
   sendTabEvent(tabId, moveInfo, "tabs.onMoved")
-);
+)
 
 chrome.tabs.onRemoved.addListener((tabId, removeInfo) =>
   sendTabEvent(tabId, removeInfo, "tabs.onRemoved")
-);
+)
 
 chrome.tabs.onUpdated.addListener((tabId, changeInfo, tab) =>
   sendTabEventFromTab(tab, changeInfo, "tabs.onUpdated")
-);
+)
 
 chrome.tabs.onZoomChange.addListener((zoomChangeInfo) =>
   sendTabEvent(zoomChangeInfo.tabId, zoomChangeInfo, "tabs.onZoomChange")
-);
+)
 
 chrome.tabs.onHighlighted.addListener((highlightInfo) => {
-    // Note: No tabId is available, so send with windowId and tabIds
-    const data = { ...highlightInfo }
-    // Loop over highlightInfo.tabIds and call sendTabEvent on each
-    for (const tabId of highlightInfo.tabIds) {
-        sendTabEvent(tabId, data, "tabs.onHighlighted")
-    }
-});
+  // Note: No tabId is available, so send with windowId and tabIds
+  const data = { ...highlightInfo }
+  // Loop over highlightInfo.tabIds and call sendTabEvent on each
+  for (const tabId of highlightInfo.tabIds) {
+    sendTabEvent(tabId, data, "tabs.onHighlighted")
+  }
+})
 
 chrome.tabs.onReplaced.addListener((addedTabId, removedTabId) => {
-    const data = { addedTabId, removedTabId }
-    sendTabEvent(addedTabId, data, "tabs.onReplaced")
-});
+  const data = { addedTabId, removedTabId }
+  sendTabEvent(addedTabId, data, "tabs.onReplaced")
+})

products/userale/package.json

@@ -1,20 +1,22 @@
-import type { PlasmoMessaging } from "@plasmohq/messaging";
-import * as userale from "flagon-userale";
-import type { StoredOptions } from "~utils/storage";
- 
-let allowListRegExp: RegExp;
+import * as userale from "flagon-userale"
+
+import type { PlasmoMessaging } from "@plasmohq/messaging"
+
+import type { StoredOptions } from "~utils/storage"
+
+let allowListRegExp: RegExp
 
 const handler: PlasmoMessaging.MessageHandler = async (req, res) => {
-  setOptions(req.body);
+  setOptions(req.body)
 }
 
 export function setOptions(options: StoredOptions) {
-  userale.options({url: options.loggingUrl});
-  allowListRegExp = new RegExp(options.allowList);
+  userale.options({ url: options.loggingUrl })
+  allowListRegExp = new RegExp(options.allowList)
 }
 
 export function getAllowListRegExp() {
-  return allowListRegExp;
+  return allowListRegExp
 }
 
-export default handler
+export default handler