Skip to content

Commit 54a83f4

Browse files
committed
update build.sh of ch
1 parent 9cc6e5b commit 54a83f4

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

ep/build-clickhouse/src/build-clickhouse.sh

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,19 @@
1717
export GLUTEN_SOURCE=$(builtin cd $(dirname $0)/../../..; pwd)
1818
export CH_SOURCE_DIR=${GLUTEN_SOURCE}/cpp-ch/ClickHouse
1919
CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE:-RelWithDebInfo}
20+
OTHER_ARGUMENTS=()
2021

2122
for arg in "$@"
2223
do
2324
case $arg in
2425
-t=*|--src=*)
25-
GLUTEN_SOURCE=("${arg#*=}")
26-
shift # Remove argument name from processing
26+
GLUTEN_SOURCE="${arg#*=}"
2727
;;
2828
-s=*|--ch=*)
29-
CH_SOURCE_DIR=("${arg#*=}")
30-
shift # Remove argument name from processing
29+
CH_SOURCE_DIR="${arg#*=}"
3130
;;
3231
*)
33-
OTHER_ARGUMENTS+=("$1")
34-
shift # Remove generic argument from processing
32+
OTHER_ARGUMENTS+=("$arg")
3533
;;
3634
esac
3735
done
@@ -40,5 +38,5 @@ echo ${GLUTEN_SOURCE}
4038

4139
export CC=${CC:-clang-18}
4240
export CXX=${CXX:-clang++-18}
43-
cmake -G Ninja -S ${GLUTEN_SOURCE}/cpp-ch -B ${GLUTEN_SOURCE}/cpp-ch/build_ch -DCH_SOURCE_DIR=${CH_SOURCE_DIR} "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}"
41+
cmake -G Ninja -S ${GLUTEN_SOURCE}/cpp-ch -B ${GLUTEN_SOURCE}/cpp-ch/build_ch -DCH_SOURCE_DIR=${CH_SOURCE_DIR} "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}" "${OTHER_ARGUMENTS[@]}"
4442
cmake --build ${GLUTEN_SOURCE}/cpp-ch/build_ch --target build_ch

0 commit comments

Comments
 (0)