Commit 5d8af9c
committed
[MINOR][VL] Re-enable stale ignored atan2 test in MathFunctionsValidateSuite
The atan2 test was marked ignore after a result mismatch (PR #1689, 2023)
caused by Velox using std::atan2 directly. That was fixed upstream in
oap-project/velox#263 which added sparksql::Atan2Function that mirrors
Spark's Math.atan2(y + 0.0, x + 0.0) behaviour to normalise -0 inputs.
The ignore was never removed after the fix landed.
Also promotes MathFunctionsValidateSuite from abstract class to class
(fixing the RAS-removal oversight from PR #11756, the same fix already
applied to DateFunctionsValidateSuite) and disables ANSI mode for Spark 4,
consistent with the approach in PR #12158 which adds further tests to this
same suite.1 parent 33be6fb commit 5d8af9c
1 file changed
Lines changed: 2 additions & 2 deletions
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
99 | | - | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| |||
0 commit comments