improve code

Author: beliefer

backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala

@@ -95,7 +95,7 @@ class VeloxConfig(conf: SQLConf) extends GlutenConfig(conf) {
   def cudfShuffleMaxPrefetchBytes: Long = getConf(CUDF_SHUFFLE_MAX_PREFETCH_BYTES)
 
   def orcUseColumnNames: Boolean = getConf(ORC_USE_COLUMN_NAMES) &&
-    !conf.getConfString(ORC_FORCE_POSITIONAL_EVOLUTION, "false").toBoolean
+    !conf.getConfString(GlutenConfig.SPARK_ORC_FORCE_POSITIONAL_EVOLUTION, "false").toBoolean
 
   def parquetUseColumnNames: Boolean = getConf(PARQUET_USE_COLUMN_NAMES)
 
@@ -809,12 +809,6 @@ object VeloxConfig extends ConfigRegistry {
       .booleanConf
       .createWithDefault(true)
 
-  // The Hadoop/ORC config that forces position-based schema evolution. When set to true,
-  // vanilla Spark reads ORC columns by position; Gluten/Velox must do the same, so it
-  // overrides ORC_USE_COLUMN_NAMES to false. Kept as a plain conf key (not a Gluten
-  // ConfigEntry) because it is a standard `spark.hadoop.*` Hadoop property.
-  val ORC_FORCE_POSITIONAL_EVOLUTION = "spark.hadoop.orc.force.positional.evolution"
-
   val PARQUET_USE_COLUMN_NAMES =
     buildConf("spark.gluten.sql.columnar.backend.velox.parquetUseColumnNames")
       .doc("Maps table field names to file field names using names, not indices for Parquet files.")

backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala

@@ -354,7 +354,7 @@ class FallbackSuite extends VeloxWholeStageTransformerSuite with AdaptiveSparkPl
       forcePositional =>
         withSQLConf(
           VeloxConfig.ORC_USE_COLUMN_NAMES.key -> "true",
-          VeloxConfig.ORC_FORCE_POSITIONAL_EVOLUTION -> forcePositional
+          GlutenConfig.SPARK_ORC_FORCE_POSITIONAL_EVOLUTION -> forcePositional
         ) {
           withTable("test") {
             spark

gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala

@@ -433,6 +433,8 @@ object GlutenConfig extends ConfigRegistry {
   val SPARK_S3_ENDPOINT_REGION: String = HADOOP_PREFIX + S3_ENDPOINT_REGION
   val S3_AWS_IMDS_ENABLED = "fs.s3a.aws.imds.enabled"
   val SPARK_S3_AWS_IMDS_ENABLED: String = HADOOP_PREFIX + S3_AWS_IMDS_ENABLED
+  val ORC_FORCE_POSITIONAL_EVOLUTION = "orc.force.positional.evolution"
+  val SPARK_ORC_FORCE_POSITIONAL_EVOLUTION = HADOOP_PREFIX + ORC_FORCE_POSITIONAL_EVOLUTION
 
   // ABFS config
   val ABFS_PREFIX = "fs.azure."
@@ -582,7 +584,7 @@ object GlutenConfig extends ConfigRegistry {
     // reads columns back as null/empty. Override the (Velox) orcUseColumnNames session conf
     // so native reads ORC by position too. Harmless for backends that ignore this key.
     // String literal is used because gluten-substrait cannot depend on backends-velox.
-    if (conf.getOrElse("spark.hadoop.orc.force.positional.evolution", "false").toBoolean) {
+    if (conf.getOrElse(SPARK_ORC_FORCE_POSITIONAL_EVOLUTION, "false").toBoolean) {
       nativeConfMap.put("spark.gluten.sql.columnar.backend.velox.orcUseColumnNames", "false")
     }