[GLUTEN-11862][VL] Work around GMT session timezone validation failure on macOS (#11869)

Fixes #11862.

This PR works around a macOS-specific native validation failure in the Velox backend when the effective Spark session timezone is GMT.

Based on the discussion in #11862, the underlying behavior is likely related to upstream Folly/Velox timezone handling on macOS rather than a general Spark semantics problem. This patch keeps the workaround on the Gluten side so Spark session timezone values do not block native validation and execution in the Velox path.

The changes in this PR are:

normalize GMT and GMT+/-offset session timezone values to UTC-equivalent forms before passing them into native Velox query config
use the runtime session timezone in SubstraitToVeloxPlanValidator instead of hardcoding GMT
apply the same normalization when setting the Velox writer timezone config
add a regression test covering execution with spark.sql.session.timeZone=GMT
---------

Co-authored-by: Mohammad Linjawi <Mohammad.Linjawi@ibm.com>

Author: malinjawi

backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala

@@ -1910,6 +1910,14 @@ class MiscOperatorSuite extends VeloxWholeStageTransformerSuite with AdaptiveSpa
     assert(plan2.find(_.isInstanceOf[ProjectExecTransformer]).isDefined)
   }
 
+  test("cast date to timestamp with GMT session timezone") {
+    withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "GMT") {
+      runQueryAndCompare("SELECT cast(date'2023-01-02 01:01:01' as timestamp) as ts") {
+        checkGlutenPlan[ProjectExecTransformer]
+      }
+    }
+  }
+
   test("cast timestamp to date") {
     val query = "select cast(ts as date) from values (timestamp'2024-01-01 00:00:00') as tab(ts)"
     runQueryAndCompare(query) {

cpp/core/config/GlutenConfig.cc

@@ -49,6 +49,17 @@ parseConfMap(JNIEnv* env, const uint8_t* planData, const int32_t planDataLength)
   return sparkConfs;
 }
 
+std::string normalizeSessionTimezone(std::string_view sessionTimezone) {
+  if (sessionTimezone == "GMT") {
+    return "UTC";
+  }
+  if (sessionTimezone.size() > 3 && sessionTimezone.substr(0, 3) == "GMT" &&
+      (sessionTimezone[3] == '+' || sessionTimezone[3] == '-')) {
+    return std::string("UTC").append(sessionTimezone.substr(3));
+  }
+  return std::string(sessionTimezone);
+}
+
 std::string printConfig(const std::unordered_map<std::string, std::string>& conf) {
   std::ostringstream oss;
   oss << std::endl;

cpp/core/config/GlutenConfig.h

@@ -20,6 +20,7 @@
 #include <jni.h>
 #include <cstdint>
 #include <string>
+#include <string_view>
 #include <unordered_map>
 
 namespace gluten {
@@ -102,5 +103,7 @@ const std::string kDebugCudfDefault = "false";
 std::unordered_map<std::string, std::string>
 parseConfMap(JNIEnv* env, const uint8_t* planData, const int32_t planDataLength);
 
+std::string normalizeSessionTimezone(std::string_view sessionTimezone);
+
 std::string printConfig(const std::unordered_map<std::string, std::string>& conf);
 } // namespace gluten

cpp/velox/compute/WholeStageResultIterator.cc

@@ -575,7 +575,8 @@ std::unordered_map<std::string, std::string> WholeStageResultIterator::getQueryC
       std::to_string(veloxCfg_->get<uint64_t>(kVeloxPreferredBatchBytes, 10L << 20));
   try {
     configs[velox::core::QueryConfig::kSparkAnsiEnabled] = veloxCfg_->get<std::string>(kAnsiEnabled, "false");
-    configs[velox::core::QueryConfig::kSessionTimezone] = veloxCfg_->get<std::string>(kSessionTimezone, "");
+    configs[velox::core::QueryConfig::kSessionTimezone] =
+        normalizeSessionTimezone(veloxCfg_->get<std::string>(kSessionTimezone, ""));
     // Adjust timestamp according to the above configured session timezone.
     configs[velox::core::QueryConfig::kAdjustTimestampToTimezone] = "true";
 

cpp/velox/substrait/SubstraitToVeloxPlanValidator.h

@@ -31,7 +31,7 @@ class SubstraitToVeloxPlanValidator {
  public:
   SubstraitToVeloxPlanValidator(memory::MemoryPool* pool) {
     std::unordered_map<std::string, std::string> configs{
-        {velox::core::QueryConfig::kSparkPartitionId, "0"}, {velox::core::QueryConfig::kSessionTimezone, "GMT"}};
+        {velox::core::QueryConfig::kSparkPartitionId, "0"}, {velox::core::QueryConfig::kSessionTimezone, "UTC"}};
     veloxCfg_ = std::make_shared<facebook::velox::config::ConfigBase>(std::move(configs));
     planConverter_ = std::make_unique<SubstraitToVeloxPlanConverter>(
         pool, veloxCfg_.get(), std::vector<std::shared_ptr<ResultIterator>>{}, std::nullopt, std::nullopt, true);

cpp/velox/utils/VeloxWriterUtils.cc

@@ -89,7 +89,9 @@ std::unique_ptr<WriterOptions> makeParquetWriteOption(const std::unordered_map<s
   writeOption->flushPolicyFactory = [maxRowGroupRows, maxRowGroupBytes]() {
     return std::make_unique<LambdaFlushPolicy>(maxRowGroupRows, maxRowGroupBytes, [&]() { return false; });
   };
-  writeOption->parquetWriteTimestampTimeZone = getConfigValue(sparkConfs, kSessionTimezone, std::nullopt);
+  if (auto it = sparkConfs.find(kSessionTimezone); it != sparkConfs.end()) {
+    writeOption->parquetWriteTimestampTimeZone = normalizeSessionTimezone(it->second);
+  }
   writeOption->arrowMemoryPool =
       getDefaultMemoryManager()->getOrCreateArrowMemoryPool("VeloxParquetWrite.ArrowMemoryPool");
   if (auto it = sparkConfs.find(kParquetDataPageSize); it != sparkConfs.end()) {