Skip to content

Commit b96d8e8

Browse files
authored
[MINOR][VL] Re-enable stale ignored atan2 test in MathFunctionsValidateSuite (#12199)
1 parent fc90a79 commit b96d8e8

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

backends-velox/src/test/scala/org/apache/gluten/functions/MathFunctionsValidateSuite.scala

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class MathFunctionsValidateSuiteAnsiOn extends FunctionsValidateSuite {
6666
}
6767
}
6868

69-
abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
69+
class MathFunctionsValidateSuite extends FunctionsValidateSuite {
7070

7171
disableFallbackCheck
7272
import testImplicits._
@@ -96,7 +96,7 @@ abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
9696
}
9797
}
9898

99-
ignore("atan2") {
99+
test("atan2") {
100100
runQueryAndCompare("SELECT atan2(double_field1, 0) from datatab limit 1") {
101101
checkGlutenPlan[ProjectExecTransformer]
102102
}
@@ -414,7 +414,9 @@ abstract class MathFunctionsValidateSuite extends FunctionsValidateSuite {
414414
}
415415
}
416416

417-
test("decimal arithmetic respects allowPrecisionLoss captured at view analysis time") {
417+
testWithMinSparkVersion(
418+
"decimal arithmetic respects allowPrecisionLoss captured at view analysis time",
419+
"4.1") {
418420
// Regression test for GLUTEN-11917: in Spark 4.1, arithmetic expressions embed
419421
// allowPrecisionLoss in their evalContext at analysis time. Gluten must read from
420422
// the expression rather than SQLConf.get, which can differ when querying a view

0 commit comments

Comments
 (0)