Skip to content

Commit 8378617

Browse files
fuweng11baomingyu
authored andcommitted
[INLONG-10074][Manager] Fix the problem of Error in querying audit information based on IP address (#10075)
(cherry picked from commit 721d61a)
1 parent e8c81b4 commit 8378617

2 files changed

Lines changed: 3 additions & 72 deletions

File tree

inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/AuditEntityMapper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ List<Map<String, Object>> sumByLogTsAndIp(@Param(value = "ip") String ip,
6262

6363
List<Map<String, Object>> sumGroupByIp(@Param(value = "groupId") String groupId,
6464
@Param(value = "streamId") String streamId,
65+
@Param(value = "ip") String ip,
6566
@Param(value = "auditId") String auditId,
6667
@Param(value = "startDate") String startDate,
6768
@Param(value = "endData") String endData);

inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AuditServiceImpl.java

Lines changed: 2 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,6 @@
4444
import org.apache.inlong.manager.pojo.audit.AuditSourceRequest;
4545
import org.apache.inlong.manager.pojo.audit.AuditSourceResponse;
4646
import org.apache.inlong.manager.pojo.audit.AuditVO;
47-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchAggregationsTermsInfo;
48-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchAggregationsTermsInfo.Field;
49-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchAggregationsTermsInfo.Sum;
50-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchQueryInfo;
51-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchQueryInfo.QueryBool;
52-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchQuerySortInfo;
53-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchQuerySortInfo.SortValue;
54-
import org.apache.inlong.manager.pojo.node.es.ElasticsearchRequest;
5547
import org.apache.inlong.manager.pojo.user.LoginUserUtils;
5648
import org.apache.inlong.manager.pojo.user.UserRoleCode;
5749
import org.apache.inlong.manager.service.audit.AuditRunnable;
@@ -61,11 +53,8 @@
6153
import org.apache.inlong.manager.service.resource.sink.ck.ClickHouseConfig;
6254
import org.apache.inlong.manager.service.resource.sink.es.ElasticsearchApi;
6355

64-
import com.google.common.collect.Lists;
65-
import com.google.common.collect.Maps;
6656
import com.google.gson.Gson;
6757
import com.google.gson.GsonBuilder;
68-
import com.google.gson.JsonObject;
6958
import org.apache.commons.collections.CollectionUtils;
7059
import org.apache.commons.lang3.StringUtils;
7160
import org.apache.ibatis.jdbc.SQL;
@@ -369,9 +358,8 @@ public List<AuditVO> listAll(AuditRequest request) throws Exception {
369358
// Support min agg at now
370359
DateTime endDate = SECOND_DATE_FORMATTER.parseDateTime(request.getEndDate());
371360
String endDateStr = endDate.plusDays(1).toString(SECOND_DATE_FORMATTER);
372-
List<Map<String, Object>> sumList = auditEntityMapper.sumGroupByIp(
373-
request.getInlongGroupId(), request.getInlongStreamId(), auditId, request.getStartDate(),
374-
endDateStr);
361+
List<Map<String, Object>> sumList = auditEntityMapper.sumGroupByIp(request.getInlongGroupId(),
362+
request.getInlongStreamId(), request.getIp(), auditId, request.getStartDate(), endDateStr);
375363
List<AuditInfo> auditSet = sumList.stream().map(s -> {
376364
AuditInfo vo = new AuditInfo();
377365
vo.setInlongGroupId((String) s.get("inlongGroupId"));
@@ -433,64 +421,6 @@ private List<String> getAuditIds(String groupId, String streamId, String sourceN
433421
return new ArrayList<>(auditSet);
434422
}
435423

436-
/**
437-
* Convert to elasticsearch search request json
438-
*
439-
* @param groupId The groupId of inlong
440-
* @param streamId The streamId of inlong
441-
* @return The search request of elasticsearch json
442-
*/
443-
public static JsonObject toAuditSearchRequestJson(String groupId, String streamId) {
444-
Map<String, ElasticsearchQueryInfo.TermValue> groupIdMap = Maps.newHashMap();
445-
groupIdMap.put(INLONG_GROUP_ID, new ElasticsearchQueryInfo.TermValue(groupId, DEFAULT_BOOST));
446-
ElasticsearchQueryInfo.QueryTerm groupIdTerm = ElasticsearchQueryInfo.QueryTerm.builder().term(groupIdMap)
447-
.build();
448-
Map<String, ElasticsearchQueryInfo.TermValue> streamIdMap = Maps.newHashMap();
449-
streamIdMap.put(INLONG_STREAM_ID, new ElasticsearchQueryInfo.TermValue(streamId, DEFAULT_BOOST));
450-
ElasticsearchQueryInfo.QueryTerm streamIdTerm = ElasticsearchQueryInfo.QueryTerm.builder().term(streamIdMap)
451-
.build();
452-
QueryBool boolInfo = QueryBool.builder()
453-
.must(Lists.newArrayList(groupIdTerm, streamIdTerm))
454-
.boost(DEFAULT_BOOST)
455-
.adjustPureNegative(ADJUST_PURE_NEGATIVE)
456-
.build();
457-
ElasticsearchQueryInfo queryInfo = ElasticsearchQueryInfo.builder().bool(boolInfo).build();
458-
459-
Map<String, SortValue> termValueInfoMap = Maps.newHashMap();
460-
termValueInfoMap.put(TERM_FILED, new SortValue(SORT_ORDER));
461-
List<Map<String, SortValue>> list = Lists.newArrayList(termValueInfoMap);
462-
ElasticsearchQuerySortInfo sortInfo = ElasticsearchQuerySortInfo.builder().sort(list).build();
463-
464-
Sum countSum = Sum.builder()
465-
.sum(new Field(COUNT))
466-
.build();
467-
Sum delaySum = Sum.builder()
468-
.sum(new Field(DELAY))
469-
.build();
470-
Map<String, Sum> aggregations = Maps.newHashMap();
471-
aggregations.put(COUNT, countSum);
472-
aggregations.put(DELAY, delaySum);
473-
ElasticsearchAggregationsTermsInfo termsInfo = ElasticsearchAggregationsTermsInfo.builder()
474-
.field(TERM_FILED)
475-
.size(Integer.MAX_VALUE)
476-
.aggregations(aggregations)
477-
.build();
478-
Map<String, ElasticsearchAggregationsTermsInfo> terms = Maps.newHashMap();
479-
terms.put(TERMS, termsInfo);
480-
Map<String, Map<String, ElasticsearchAggregationsTermsInfo>> logTs = Maps.newHashMap();
481-
logTs.put(TERM_FILED, terms);
482-
483-
ElasticsearchRequest request = ElasticsearchRequest.builder()
484-
.from(QUERY_FROM)
485-
.size(QUERY_SIZE)
486-
.query(queryInfo)
487-
.sort(sortInfo)
488-
.aggregations(logTs)
489-
.build();
490-
491-
return GSON.toJsonTree(request).getAsJsonObject();
492-
}
493-
494424
/**
495425
* Get clickhouse Statement
496426
*

0 commit comments

Comments
 (0)