Skip to content

Commit 84913ef

Browse files
Fix redact sensitive information in commands test
1 parent 296c903 commit 84913ef

2 files changed

Lines changed: 17 additions & 2 deletions

File tree

kyuubi-server/src/test/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilderSuite.scala

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,14 @@ class FlinkProcessBuilderSuite extends KyuubiFunSuite {
211211
.set("flink.kyuubi.my.key", "non_sensitive_value")
212212

213213
val builder1 =
214-
new FlinkProcessBuilder("kyuubi", true, conf1, "", conf1.get(SERVER_SECRET_REDACTION_PATTERN))
214+
new FlinkProcessBuilder(
215+
"kyuubi",
216+
true,
217+
conf1,
218+
"",
219+
conf1.get(SERVER_SECRET_REDACTION_PATTERN)) {
220+
override def env: Map[String, String] = envWithAllHadoop
221+
}
215222
val commands1 = builder1.toString.split(' ')
216223

217224
assert(commands1.contains("flink.kyuubi.my.password=" + REDACTION_REPLACEMENT_TEXT))
@@ -225,7 +232,14 @@ class FlinkProcessBuilderSuite extends KyuubiFunSuite {
225232
.set("flink.kyuubi.my.key", "non_sensitive_value")
226233

227234
val builder2 =
228-
new FlinkProcessBuilder("kyuubi", true, conf2, "", conf2.get(SERVER_SECRET_REDACTION_PATTERN))
235+
new FlinkProcessBuilder(
236+
"kyuubi",
237+
true,
238+
conf2,
239+
"",
240+
conf2.get(SERVER_SECRET_REDACTION_PATTERN)) {
241+
override def env: Map[String, String] = envWithAllHadoop
242+
}
229243
val commands2 = builder2.toString.split(' ')
230244

231245
assert(commands2.exists(_.contains("kyuubi.my.password=" + REDACTION_REPLACEMENT_TEXT)))

kyuubi-server/src/test/scala/org/apache/kyuubi/engine/hive/HiveProcessBuilderSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ class HiveProcessBuilderSuite extends KyuubiFunSuite {
7474

7575
test("redact sensitive information in commands") {
7676
val conf = KyuubiConf()
77+
.set(ENGINE_HIVE_EXTRA_CLASSPATH, "/hadoop")
7778
.set(SERVER_SECRET_REDACTION_PATTERN, "(?i)secret|password".r)
7879
.set("hive.kyuubi.my.password", "sensitive_value")
7980
.set("hive.kyuubi.my.secret", "sensitive_value")

0 commit comments

Comments
 (0)