Skip to content

Commit 44add4d

Browse files
committed
ci(symfony): run upgrade-filter --force then the functional suite
The fixture sweep is complete, so guard both migration paths: --force must run cleanly (re-skipping the special cases) and the functional suite must pass against the migrated QueryParameter and Legacy/ #[ApiFilter] fixtures.
1 parent 365bfd8 commit 44add4d

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,13 @@ jobs:
158158
composer global link .
159159
- name: Codemod unit tests
160160
run: vendor/bin/phpunit src/Symfony/Tests/Bundle/Command
161-
# Smoke: the codemod must run over every resource without error.
162-
# TODO: once the #[ApiFilter] fixture sweep completes (special cases handled),
163-
# switch this to `--force` followed by the full test suite to guard both paths.
164-
- name: Codemod dry-run smoke
165-
run: tests/Fixtures/app/console api:upgrade-filter --dry-run
161+
# The #[ApiFilter] fixtures are already migrated in the tree, so --force only re-skips the
162+
# special cases (name conversion, service/#[ApiFilter] key overlap); it must not error.
163+
- name: Codemod force run
164+
run: tests/Fixtures/app/console api:upgrade-filter --force
165+
# Guard both paths: the migrated QueryParameter fixtures and the Legacy/ #[ApiFilter] fixtures.
166+
- name: Functional suite
167+
run: vendor/bin/phpunit tests/Functional
166168

167169
phpstan:
168170
name: PHPStan (PHP ${{ matrix.php }})

0 commit comments

Comments
 (0)