chore(metadata): remove stale 3.0 TODO in IdentifiersExtractor

soyuka · soyuka · commit 6523e1ddf259 · 2026-06-30T17:23:19.000+02:00
resolveIdentifierValue already resolves via instanceof \Stringable
(plus scalar and BackedEnum); the TODO about a 3.0 cleanup is obsolete.
diff --git a/src/Metadata/IdentifiersExtractor.php b/src/Metadata/IdentifiersExtractor.php
@@ -177,11 +177,6 @@ private function getIdentifierValue(object $item, string $class, string $propert
         throw new RuntimeException('Not able to retrieve identifiers.');
     }
 
-    /**
-     * TODO: in 3.0 this method just uses $identifierValue instanceof \Stringable and we remove the weird behavior.
-     *
-     * @param mixed|\Stringable $identifierValue
-     */
     private function resolveIdentifierValue(mixed $identifierValue, string $parameterName): float|bool|int|string
     {
         if (null === $identifierValue) {

Original file line number	Diff line number	Diff line change
`@@ -177,11 +177,6 @@ private function getIdentifierValue(object $item, string $class, string $propert`
`177`	`177`	`throw new RuntimeException('Not able to retrieve identifiers.');`
`178`	`178`	`}`
`179`	`179`
`180`		`- /**`
`181`		`- * TODO: in 3.0 this method just uses $identifierValue instanceof \Stringable and we remove the weird behavior.`
`182`		`- *`
`183`		`- * @param mixed\|\Stringable $identifierValue`
`184`		`- */`
`185`	`180`	`private function resolveIdentifierValue(mixed $identifierValue, string $parameterName): float\|bool\|int\|string`
`186`	`181`	`{`
`187`	`182`	`if (null === $identifierValue) {`