Skip to content

Commit 868ac56

Browse files
loic425loic425
committed
feat(metadata): customize resource & operations
1 parent cff61ea commit 868ac56

15 files changed

Lines changed: 521 additions & 134 deletions

‎src/Metadata/Extractor/AbstractClosureExtractor.php‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the API Platform project.
5+
*
6+
* (c) Kévin Dunglas <dunglas@gmail.com>
7+
*
8+
* For the full copyright and license information, please view the LICENSE
9+
* file that was distributed with this source code.
10+
*/
11+
12+
declare(strict_types=1);
13+
14+
namespace ApiPlatform\Metadata\Extractor;
15+
16+
use Psr\Container\ContainerInterface;
17+
18+
/**
19+
* Base file extractor.
20+
*
21+
* @author Loïc Frémont <lc.fremont@gmail.com>
22+
*/
23+
abstract class AbstractClosureExtractor implements ClosureExtractorInterface
24+
{
25+
use ResolveValueTrait;
26+
27+
protected ?array $closures = null;
28+
private array $collectedParameters = [];
29+
30+
/**
31+
* @param string[] $paths
32+
*/
33+
public function __construct(protected array $paths, private readonly ?ContainerInterface $container = null)
34+
{
35+
}
36+
37+
/**
38+
* {@inheritdoc}
39+
*/
40+
public function getClosures(): array
41+
{
42+
if (null !== $this->closures) {
43+
return $this->closures;
44+
}
45+
46+
$this->closures = [];
47+
foreach ($this->paths as $path) {
48+
$closure = $this->getPHPFileClosure($path)();
49+
50+
if (!$closure instanceof \Closure || !$this->isClosureSupported($closure)) {
51+
continue;
52+
}
53+
54+
$this->closures[] = $closure;
55+
}
56+
57+
return $this->closures;
58+
}
59+
60+
/**
61+
* Check if the closure is supported.
62+
*/
63+
abstract protected function isClosureSupported(\Closure $closure): bool;
64+
65+
/**
66+
* Scope isolated include.
67+
*
68+
* Prevents access to $this/self from included files.
69+
*/
70+
protected function getPHPFileClosure(string $filePath): \Closure
71+
{
72+
return \Closure::bind(function () use ($filePath): mixed {
73+
return require $filePath;
74+
}, null, null);
75+
}
76+
}

‎src/Metadata/Extractor/AbstractPropertyExtractor.php‎

Lines changed: 2 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
namespace ApiPlatform\Metadata\Extractor;
1515

1616
use Psr\Container\ContainerInterface;
17-
use Symfony\Component\DependencyInjection\ContainerInterface as SymfonyContainerInterface;
1817

1918
/**
2019
* Base file extractor.
@@ -23,6 +22,8 @@
2322
*/
2423
abstract class AbstractPropertyExtractor implements PropertyExtractorInterface
2524
{
25+
use ResolveValueTrait;
26+
2627
protected ?array $properties = null;
2728
private array $collectedParameters = [];
2829

@@ -54,70 +55,4 @@ public function getProperties(): array
5455
* Extracts metadata from a given path.
5556
*/
5657
abstract protected function extractPath(string $path): void;
57-
58-
/**
59-
* Recursively replaces placeholders with the service container parameters.
60-
*
61-
* @see https://github.com/symfony/symfony/blob/6fec32c/src/Symfony/Bundle/FrameworkBundle/Routing/Router.php
62-
*
63-
* @copyright (c) Fabien Potencier <fabien@symfony.com>
64-
*
65-
* @param mixed $value The source which might contain "%placeholders%"
66-
*
67-
* @throws \RuntimeException When a container value is not a string or a numeric value
68-
*
69-
* @return mixed The source with the placeholders replaced by the container
70-
* parameters. Arrays are resolved recursively.
71-
*/
72-
protected function resolve(mixed $value): mixed
73-
{
74-
if (null === $this->container) {
75-
return $value;
76-
}
77-
78-
if (\is_array($value)) {
79-
foreach ($value as $key => $val) {
80-
$value[$key] = $this->resolve($val);
81-
}
82-
83-
return $value;
84-
}
85-
86-
if (!\is_string($value)) {
87-
return $value;
88-
}
89-
90-
$escapedValue = preg_replace_callback('/%%|%([^%\s]++)%/', function ($match) use ($value) {
91-
$parameter = $match[1] ?? null;
92-
93-
// skip %%
94-
if (!isset($parameter)) {
95-
return '%%';
96-
}
97-
98-
if (preg_match('/^env\(\w+\)$/', $parameter)) {
99-
throw new \RuntimeException(\sprintf('Using "%%%s%%" is not allowed in routing configuration.', $parameter));
100-
}
101-
102-
if (\array_key_exists($parameter, $this->collectedParameters)) {
103-
return $this->collectedParameters[$parameter];
104-
}
105-
106-
if ($this->container instanceof SymfonyContainerInterface) {
107-
$resolved = $this->container->getParameter($parameter);
108-
} else {
109-
$resolved = $this->container->get($parameter);
110-
}
111-
112-
if (\is_string($resolved) || is_numeric($resolved)) {
113-
$this->collectedParameters[$parameter] = $resolved;
114-
115-
return (string) $resolved;
116-
}
117-
118-
throw new \RuntimeException(\sprintf('The container parameter "%s", used in the resource configuration value "%s", must be a string or numeric, but it is of type %s.', $parameter, $value, \gettype($resolved)));
119-
}, $value);
120-
121-
return str_replace('%%', '%', $escapedValue);
122-
}
12358
}

‎src/Metadata/Extractor/AbstractResourceExtractor.php‎

Lines changed: 2 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
namespace ApiPlatform\Metadata\Extractor;
1515

1616
use Psr\Container\ContainerInterface;
17-
use Symfony\Component\DependencyInjection\ContainerInterface as SymfonyContainerInterface;
1817

1918
/**
2019
* Base file extractor.
@@ -23,6 +22,8 @@
2322
*/
2423
abstract class AbstractResourceExtractor implements ResourceExtractorInterface
2524
{
25+
use ResolveValueTrait;
26+
2627
protected ?array $resources = null;
2728
private array $collectedParameters = [];
2829

@@ -54,70 +55,4 @@ public function getResources(): array
5455
* Extracts metadata from a given path.
5556
*/
5657
abstract protected function extractPath(string $path): void;
57-
58-
/**
59-
* Recursively replaces placeholders with the service container parameters.
60-
*
61-
* @see https://github.com/symfony/symfony/blob/6fec32c/src/Symfony/Bundle/FrameworkBundle/Routing/Router.php
62-
*
63-
* @copyright (c) Fabien Potencier <fabien@symfony.com>
64-
*
65-
* @param mixed $value The source which might contain "%placeholders%"
66-
*
67-
* @throws \RuntimeException When a container value is not a string or a numeric value
68-
*
69-
* @return mixed The source with the placeholders replaced by the container
70-
* parameters. Arrays are resolved recursively.
71-
*/
72-
protected function resolve(mixed $value): mixed
73-
{
74-
if (null === $this->container) {
75-
return $value;
76-
}
77-
78-
if (\is_array($value)) {
79-
foreach ($value as $key => $val) {
80-
$value[$key] = $this->resolve($val);
81-
}
82-
83-
return $value;
84-
}
85-
86-
if (!\is_string($value)) {
87-
return $value;
88-
}
89-
90-
$escapedValue = preg_replace_callback('/%%|%([^%\s]++)%/', function ($match) use ($value) {
91-
$parameter = $match[1] ?? null;
92-
93-
// skip %%
94-
if (!isset($parameter)) {
95-
return '%%';
96-
}
97-
98-
if (preg_match('/^env\(\w+\)$/', $parameter)) {
99-
throw new \RuntimeException(\sprintf('Using "%%%s%%" is not allowed in routing configuration.', $parameter));
100-
}
101-
102-
if (\array_key_exists($parameter, $this->collectedParameters)) {
103-
return $this->collectedParameters[$parameter];
104-
}
105-
106-
if ($this->container instanceof SymfonyContainerInterface) {
107-
$resolved = $this->container->getParameter($parameter);
108-
} else {
109-
$resolved = $this->container->get($parameter);
110-
}
111-
112-
if (\is_string($resolved) || is_numeric($resolved)) {
113-
$this->collectedParameters[$parameter] = $resolved;
114-
115-
return (string) $resolved;
116-
}
117-
118-
throw new \RuntimeException(\sprintf('The container parameter "%s", used in the resource configuration value "%s", must be a string or numeric, but it is of type %s.', $parameter, $value, \gettype($resolved)));
119-
}, $value);
120-
121-
return str_replace('%%', '%', $escapedValue);
122-
}
12358
}

‎src/Metadata/Extractor/ClosureExtractorInterface.php‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the API Platform project.
5+
*
6+
* (c) Kévin Dunglas <dunglas@gmail.com>
7+
*
8+
* For the full copyright and license information, please view the LICENSE
9+
* file that was distributed with this source code.
10+
*/
11+
12+
declare(strict_types=1);
13+
14+
namespace ApiPlatform\Metadata\Extractor;
15+
16+
use ApiPlatform\Metadata\Exception\InvalidArgumentException;
17+
18+
/**
19+
* Extracts an array of closure from a file or a list of files.
20+
*
21+
* @author Loïc Frémont <lc.fremont@gmail.com>
22+
*/
23+
interface ClosureExtractorInterface
24+
{
25+
/**
26+
* Parses all metadata files and convert them in an array.
27+
*
28+
* @throws InvalidArgumentException
29+
*/
30+
public function getClosures(): array;
31+
}

‎src/Metadata/Extractor/PhpFileResourceClosureExtractor.php‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the API Platform project.
5+
*
6+
* (c) Kévin Dunglas <dunglas@gmail.com>
7+
*
8+
* For the full copyright and license information, please view the LICENSE
9+
* file that was distributed with this source code.
10+
*/
11+
12+
declare(strict_types=1);
13+
14+
namespace ApiPlatform\Metadata\Extractor;
15+
16+
use ApiPlatform\Metadata\ApiResource;
17+
18+
/**
19+
* Extracts an array of closure from a list of PHP files.
20+
*
21+
* @author Loïc Frémont <lc.fremont@gmail.com>
22+
*/
23+
final class PhpFileResourceClosureExtractor extends AbstractClosureExtractor
24+
{
25+
/**
26+
* {@inheritdoc}
27+
*/
28+
protected function isClosureSupported(\Closure $closure): bool
29+
{
30+
$resourceReflection = new \ReflectionFunction($closure);
31+
32+
if (1 !== $resourceReflection->getNumberOfParameters()) {
33+
return false;
34+
}
35+
36+
$firstParameterType = ($resourceReflection->getParameters()[0] ?? null)?->getType();
37+
38+
if (!$firstParameterType instanceof \ReflectionNamedType) {
39+
return false;
40+
}
41+
42+
// Check if the closure parameter is an API resource
43+
return is_a($firstParameterType->getName(), ApiResource::class, true);
44+
}
45+
}

0 commit comments

Comments
 (0)