refactor(doctrine): make DateFilter standalone, drop AbstractFilter

DateFilter (ORM + ODM) stops extending the deprecated AbstractFilter, the
last of the three 5.0 survivors (after ExistsFilter). It stays a genuine
survivor rather than a ComparisonFilter overlay: its date semantics —
isDateField, \DateTime/\DateTimeImmutable coercion by column immutability,
typed setParameter, and the INCLUDE_NULL_* null-management — are not
expressible through ComparisonFilter.

The decouple is structural: the AbstractFilter::apply() loop is reintroduced
as a local apply() (driving filterProperty over $context['filters'], the
universal value source for both legacy and QueryParameter declarations), and
the inherited helpers (ctor, properties accessors, isPropertyEnabled,
name-converter handling, logger) are inlined. ManagerRegistryAwareInterface
is kept for BC injection and the deprecated getDescription(); the ORM filter
reads class metadata from $queryBuilder->getEntityManager() so the active
path no longer depends on the registry, while ODM keeps it (its aggregation
Builder exposes no DocumentManager).

Author: soyuka

src/Doctrine/Common/Filter/NameConverterAwareTrait.php

@@ -0,0 +1,59 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Doctrine\Common\Filter;
+
+use Symfony\Component\Serializer\NameConverter\NameConverterInterface;
+
+/**
+ * Holds an optional name converter and (de)normalizes property names through it.
+ *
+ * @author Antoine Bluchet <soyuka@gmail.com>
+ */
+trait NameConverterAwareTrait
+{
+    private ?NameConverterInterface $nameConverter = null;
+
+    public function hasNameConverter(): bool
+    {
+        return $this->nameConverter instanceof NameConverterInterface;
+    }
+
+    public function getNameConverter(): ?NameConverterInterface
+    {
+        return $this->nameConverter;
+    }
+
+    public function setNameConverter(NameConverterInterface $nameConverter): void
+    {
+        $this->nameConverter = $nameConverter;
+    }
+
+    protected function denormalizePropertyName(string|int $property): string
+    {
+        if (!$this->nameConverter instanceof NameConverterInterface) {
+            return (string) $property;
+        }
+
+        return implode('.', array_map($this->nameConverter->denormalize(...), explode('.', (string) $property)));
+    }
+
+    protected function normalizePropertyName(string $property): string
+    {
+        if (!$this->nameConverter instanceof NameConverterInterface) {
+            return $property;
+        }
+
+        return implode('.', array_map($this->nameConverter->normalize(...), explode('.', $property)));
+    }
+}

src/Doctrine/Common/Filter/PropertyAwareFilterTrait.php

@@ -0,0 +1,38 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Doctrine\Common\Filter;
+
+/**
+ * @author Antoine Bluchet <soyuka@gmail.com>
+ */
+trait PropertyAwareFilterTrait
+{
+    /**
+     * @var array<string, mixed>|null
+     */
+    private ?array $properties = null;
+
+    public function getProperties(): ?array
+    {
+        return $this->properties;
+    }
+
+    /**
+     * @param array<string, mixed> $properties
+     */
+    public function setProperties(array $properties): void
+    {
+        $this->properties = $properties;
+    }
+}

src/Doctrine/Odm/Filter/DateFilter.php

@@ -15,6 +15,13 @@
 
 use ApiPlatform\Doctrine\Common\Filter\DateFilterInterface;
 use ApiPlatform\Doctrine\Common\Filter\DateFilterTrait;
+use ApiPlatform\Doctrine\Common\Filter\ManagerRegistryAwareInterface;
+use ApiPlatform\Doctrine\Common\Filter\ManagerRegistryAwareTrait;
+use ApiPlatform\Doctrine\Common\Filter\NameConverterAwareInterface;
+use ApiPlatform\Doctrine\Common\Filter\NameConverterAwareTrait;
+use ApiPlatform\Doctrine\Common\Filter\PropertyAwareFilterInterface;
+use ApiPlatform\Doctrine\Common\Filter\PropertyAwareFilterTrait;
+use ApiPlatform\Doctrine\Odm\PropertyHelperTrait as MongoDbOdmPropertyHelperTrait;
 use ApiPlatform\Metadata\Exception\InvalidArgumentException;
 use ApiPlatform\Metadata\JsonSchemaFilterInterface;
 use ApiPlatform\Metadata\OpenApiParameterFilterInterface;
@@ -23,6 +30,10 @@
 use ApiPlatform\Metadata\QueryParameter;
 use ApiPlatform\OpenApi\Model\Parameter as OpenApiParameter;
 use Doctrine\ODM\MongoDB\Aggregation\Builder;
+use Doctrine\Persistence\ManagerRegistry;
+use Psr\Log\LoggerInterface;
+use Psr\Log\NullLogger;
+use Symfony\Component\Serializer\NameConverter\NameConverterInterface;
 
 /**
  * The date filter allows to filter a collection by date intervals.
@@ -120,20 +131,59 @@
  * @author Kévin Dunglas <dunglas@gmail.com>
  * @author Théo FIDRY <theo.fidry@gmail.com>
  * @author Alan Poulain <contact@alanpoulain.eu>
- *
- * @deprecated since API Platform 4.4: extending {@see AbstractFilter} is deprecated. In 5.0 this filter is rewritten as a standalone overlay over {@see ComparisonFilter} (translating the `[before]`/`[strictly_before]`/`[after]`/`[strictly_after]` syntax) — same class name, same URL syntax, drop-in. Declare it through a QueryParameter to migrate.
  */
-final class DateFilter extends AbstractFilter implements DateFilterInterface, JsonSchemaFilterInterface, OpenApiParameterFilterInterface
+final class DateFilter implements DateFilterInterface, FilterInterface, JsonSchemaFilterInterface, ManagerRegistryAwareInterface, NameConverterAwareInterface, OpenApiParameterFilterInterface, PropertyAwareFilterInterface
 {
     use DateFilterTrait;
+    use ManagerRegistryAwareTrait;
+    use MongoDbOdmPropertyHelperTrait;
+    use NameConverterAwareTrait;
+    use PropertyAwareFilterTrait;
 
     public const DOCTRINE_DATE_TYPES = [
         'date' => true,
         'date_immutable' => true,
     ];
 
+    private LoggerInterface $logger;
+
+    /**
+     * @param array<string, mixed>|null $properties
+     */
+    public function __construct(?ManagerRegistry $managerRegistry = null, ?LoggerInterface $logger = null, ?array $properties = null, ?NameConverterInterface $nameConverter = null)
+    {
+        $this->managerRegistry = $managerRegistry;
+        $this->logger = $logger ?? new NullLogger();
+        $this->properties = $properties;
+        $this->nameConverter = $nameConverter;
+    }
+
+    public function apply(Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
+    {
+        foreach ($context['filters'] ?? [] as $property => $value) {
+            $this->filterProperty($this->denormalizePropertyName($property), $value, $aggregationBuilder, $resourceClass, $operation, $context);
+        }
+    }
+
+    protected function getLogger(): LoggerInterface
+    {
+        return $this->logger;
+    }
+
+    protected function isPropertyEnabled(string $property, string $resourceClass): bool
+    {
+        if (null === $this->properties) {
+            // to ensure sanity, nested properties must still be explicitly enabled
+            return !$this->isPropertyNested($property, $resourceClass);
+        }
+
+        return \array_key_exists($property, $this->properties);
+    }
+
     /**
-     * {@inheritdoc}
+     * @param array<string, mixed> $context
+     *
+     * @param-out array<string, mixed> $context
      */
     protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {

src/Doctrine/Odm/Filter/ExistsFilter.php

@@ -18,7 +18,9 @@
 use ApiPlatform\Doctrine\Common\Filter\ManagerRegistryAwareInterface;
 use ApiPlatform\Doctrine\Common\Filter\ManagerRegistryAwareTrait;
 use ApiPlatform\Doctrine\Common\Filter\NameConverterAwareInterface;
+use ApiPlatform\Doctrine\Common\Filter\NameConverterAwareTrait;
 use ApiPlatform\Doctrine\Common\Filter\PropertyAwareFilterInterface;
+use ApiPlatform\Doctrine\Common\Filter\PropertyAwareFilterTrait;
 use ApiPlatform\Doctrine\Common\Filter\PropertyPlaceholderOpenApiParameterTrait;
 use ApiPlatform\Doctrine\Odm\PropertyHelperTrait as MongoDbOdmPropertyHelperTrait;
 use ApiPlatform\Metadata\JsonSchemaFilterInterface;
@@ -122,45 +124,21 @@ final class ExistsFilter implements ExistsFilterInterface, FilterInterface, Json
     use ExistsFilterTrait;
     use ManagerRegistryAwareTrait;
     use MongoDbOdmPropertyHelperTrait;
+    use NameConverterAwareTrait;
+    use PropertyAwareFilterTrait;
     use PropertyPlaceholderOpenApiParameterTrait;
 
     private LoggerInterface $logger;
 
     /**
      * @param array<string, mixed>|null $properties
      */
-    public function __construct(?ManagerRegistry $managerRegistry = null, ?LoggerInterface $logger = null, private ?array $properties = null, string $existsParameterName = self::QUERY_PARAMETER_KEY, private ?NameConverterInterface $nameConverter = null)
+    public function __construct(?ManagerRegistry $managerRegistry = null, ?LoggerInterface $logger = null, ?array $properties = null, string $existsParameterName = self::QUERY_PARAMETER_KEY, ?NameConverterInterface $nameConverter = null)
     {
         $this->managerRegistry = $managerRegistry;
         $this->logger = $logger ?? new NullLogger();
         $this->existsParameterName = $existsParameterName;
-    }
-
-    public function getProperties(): ?array
-    {
-        return $this->properties;
-    }
-
-    /**
-     * @param array<string, mixed> $properties
-     */
-    public function setProperties(array $properties): void
-    {
         $this->properties = $properties;
-    }
-
-    public function hasNameConverter(): bool
-    {
-        return $this->nameConverter instanceof NameConverterInterface;
-    }
-
-    public function getNameConverter(): ?NameConverterInterface
-    {
-        return $this->nameConverter;
-    }
-
-    public function setNameConverter(NameConverterInterface $nameConverter): void
-    {
         $this->nameConverter = $nameConverter;
     }
 
@@ -179,24 +157,6 @@ protected function isPropertyEnabled(string $property, string $resourceClass): b
         return \array_key_exists($property, $this->properties);
     }
 
-    protected function denormalizePropertyName(string|int $property): string
-    {
-        if (!$this->nameConverter instanceof NameConverterInterface) {
-            return (string) $property;
-        }
-
-        return implode('.', array_map($this->nameConverter->denormalize(...), explode('.', (string) $property)));
-    }
-
-    protected function normalizePropertyName(string $property): string
-    {
-        if (!$this->nameConverter instanceof NameConverterInterface) {
-            return $property;
-        }
-
-        return implode('.', array_map($this->nameConverter->normalize(...), explode('.', $property)));
-    }
-
     /**
      * {@inheritdoc}
      */
@@ -215,7 +175,9 @@ public function apply(Builder $aggregationBuilder, string $resourceClass, ?Opera
     }
 
     /**
-     * {@inheritdoc}
+     * @param array<string, mixed> $context
+     *
+     * @param-out array<string, mixed> $context
      */
     protected function filterProperty(string $property, mixed $value, Builder $aggregationBuilder, string $resourceClass, ?Operation $operation = null, array &$context = []): void
     {