refactor: introduce inputClass ouputClass dataClass everywhere

Author: Thibaut Cholley

src/Doctrine/Odm/Metadata/Resource/DoctrineMongoDbOdmParameterResourceMetadataCollectionFactory.php

@@ -13,7 +13,6 @@
 
 namespace ApiPlatform\Doctrine\Odm\Metadata\Resource;
 
-use ApiPlatform\Doctrine\Odm\State\Options;
 use ApiPlatform\Metadata\Operation;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
@@ -79,7 +78,7 @@ private function enrichOperation(Operation $operation, string $resourceClass): O
             return $operation;
         }
 
-        $documentClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);
+        $documentClass = $operation->getDataClass();
         if (!$this->managerRegistry->getManagerForClass($documentClass) instanceof DocumentManager) {
             return $operation;
         }

src/Doctrine/Odm/Metadata/Resource/DoctrineMongoDbOdmResourceCollectionMetadataFactory.php

@@ -45,7 +45,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
 
             if ($operations) {
                 foreach ($resourceMetadata->getOperations() as $operationName => $operation) {
-                    $documentClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);
+                    $documentClass = $operation->getDataClass();
                     if (!$this->managerRegistry->getManagerForClass($documentClass) instanceof DocumentManager) {
                         continue;
                     }
@@ -62,7 +62,7 @@ public function create(string $resourceClass): ResourceMetadataCollection
 
             if ($graphQlOperations) {
                 foreach ($graphQlOperations as $operationName => $graphQlOperation) {
-                    $documentClass = $this->getStateOptionsClass($graphQlOperation, $graphQlOperation->getClass(), Options::class);
+                    $documentClass = $graphQlOperation->getDataClass();
                     if (!$this->managerRegistry->getManagerForClass($documentClass) instanceof DocumentManager) {
                         continue;
                     }

src/Doctrine/Odm/Serializer/DoctrineOdmOperationResourceClassResolver.php

@@ -44,7 +44,7 @@ public function resolve(object|string $resource, Operation $operation): string
 
             // Validate object matches the backing document class
             if ($documentClass && is_a($objectClass, $documentClass, true)) {
-                return $operation->getClass();
+                return $operation->getApiClass();
             }
         }
 

src/Doctrine/Odm/State/CollectionProvider.php

@@ -47,7 +47,7 @@ public function __construct(ResourceMetadataCollectionFactoryInterface $resource
 
     public function provide(Operation $operation, array $uriVariables = [], array $context = []): iterable
     {
-        $documentClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);
+        $documentClass = $operation->getDataClass();
 
         /** @var DocumentManager $manager */
         $manager = $this->managerRegistry->getManagerForClass($documentClass);

src/Doctrine/Odm/State/ItemProvider.php

@@ -50,7 +50,7 @@ public function __construct(ResourceMetadataCollectionFactoryInterface $resource
 
     public function provide(Operation $operation, array $uriVariables = [], array $context = []): ?object
     {
-        $documentClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);
+        $documentClass = $operation->getDataClass();
 
         /** @var DocumentManager $manager */
         $manager = $this->managerRegistry->getManagerForClass($documentClass);

src/Doctrine/Odm/State/LinksHandlerTrait.php

@@ -133,15 +133,15 @@ private function buildAggregation(string $toClass, array $links, array $identifi
 
     private function getLinkFromClass(Link $link, Operation $operation): string
     {
-        $documentClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);
+        $documentClass = $operation->getDataClass();
         $fromClass = $link->getFromClass();
-        if ($fromClass === $operation->getClass() && $documentClass) {
+        if ($fromClass === $operation->getApiClass() && $documentClass) {
             return $documentClass;
         }
 
         $operation = $this->resourceMetadataCollectionFactory->create($fromClass)->getOperation();
 
-        if ($documentClass = $this->getStateOptionsClass($operation, null, Options::class)) {
+        if ($documentClass = $operation->getDataClass()) {
             return $documentClass;
         }
 

src/Doctrine/Odm/State/Options.php

@@ -14,9 +14,9 @@
 namespace ApiPlatform\Doctrine\Odm\State;
 
 use ApiPlatform\Doctrine\Common\State\Options as CommonOptions;
-use ApiPlatform\State\OptionsInterface;
+use ApiPlatform\State\DataOptionsInterface;
 
-class Options extends CommonOptions implements OptionsInterface
+class Options extends CommonOptions implements DataOptionsInterface
 {
     /**
      * @param mixed $handleLinks experimental callable, typed mixed as we may want a service name in the future
@@ -30,6 +30,11 @@ public function __construct(
         parent::__construct(handleLinks: $handleLinks);
     }
 
+    public function getDataClass(): ?string
+    {
+        return $this->documentClass;
+    }
+
     public function getDocumentClass(): ?string
     {
         return $this->documentClass;

src/Doctrine/Odm/Tests/Metadata/Resource/DoctrineMongoDbOdmResourceCollectionMetadataFactoryTest.php

@@ -42,7 +42,7 @@ private function getResourceMetadataCollectionFactory(HttpOperation $operation)
         }
 
         $resourceMetadataCollectionFactory = $this->prophesize(ResourceMetadataCollectionFactoryInterface::class);
-        $resourceMetadataCollectionFactory->create($operation->getClass())->willReturn(new ResourceMetadataCollection($operation->getClass(), [
+        $resourceMetadataCollectionFactory->create($operation->getApiClass())->willReturn(new ResourceMetadataCollection($operation->getApiClass(), [
             (new ApiResource())
                 ->withOperations(
                     new Operations([$operation->getName() => $operation])
@@ -80,9 +80,9 @@ public function testWithProvider(HttpOperation $operation, ?string $expectedProv
 
         $objectManager = $this->prophesize(DocumentManager::class);
         $managerRegistry = $this->prophesize(ManagerRegistry::class);
-        $managerRegistry->getManagerForClass($operation->getClass())->willReturn($objectManager->reveal());
+        $managerRegistry->getManagerForClass($operation->getApiClass())->willReturn($objectManager->reveal());
         $resourceMetadataCollectionFactory = new DoctrineMongoDbOdmResourceCollectionMetadataFactory($managerRegistry->reveal(), $this->getResourceMetadataCollectionFactory($operation));
-        $resourceMetadataCollection = $resourceMetadataCollectionFactory->create($operation->getClass());
+        $resourceMetadataCollection = $resourceMetadataCollectionFactory->create($operation->getApiClass());
         $this->assertSame($expectedProvider, $resourceMetadataCollection->getOperation($operation->getName())->getProvider());
         $this->assertSame($expectedProvider, $resourceMetadataCollection->getOperation('graphql_'.$operation->getName())->getProvider());
         $this->assertSame($expectedProcessor, $resourceMetadataCollection->getOperation($operation->getName())->getProcessor());

src/Doctrine/Orm/Metadata/Resource/DoctrineOrmLinkFactory.php

@@ -54,7 +54,7 @@ public function createLinksFromRelations(Metadata $operation): array
     {
         $links = $this->linkFactory->createLinksFromRelations($operation);
 
-        $resourceClass = $operation->getClass();
+        $resourceClass = $operation->getDataClass();
         if (!($manager = $this->managerRegistry->getManagerForClass($resourceClass)) instanceof EntityManagerInterface) {
             return $links;
         }

src/Doctrine/Orm/Metadata/Resource/DoctrineOrmParameterResourceMetadataCollectionFactory.php

@@ -13,7 +13,6 @@
 
 namespace ApiPlatform\Doctrine\Orm\Metadata\Resource;
 
-use ApiPlatform\Doctrine\Orm\State\Options;
 use ApiPlatform\Metadata\Operation;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
@@ -77,7 +76,7 @@ private function enrichOperation(Operation $operation, string $resourceClass): O
             return $operation;
         }
 
-        $entityClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);
+        $entityClass = $operation->getDataClass();
         if (!$this->managerRegistry->getManagerForClass($entityClass) instanceof EntityManagerInterface) {
             return $operation;
         }