fix: remove noisy implicit configuration warning from service locator (#3837)

Fixes #3582

Author: barjin

packages/basic-crawler/src/internals/basic-crawler.ts

@@ -823,6 +823,9 @@ export class BasicCrawler<
 
             this.#log = serviceLocator.getLogger().child({ prefix: this.constructor.name });
 
+            // Initialize the Configuration instance to avoid lazy loading in the components
+            serviceLocator.getConfiguration();
+
             // Store whether the user explicitly provided an ID
             this.hasExplicitId = id !== undefined;
             // Store the user-provided ID, or generate a unique one for tracking purposes (not for state key)

packages/core/test/core/service_locator.test.ts

@@ -128,6 +128,25 @@ describe('ServiceLocator', () => {
                 serviceLocator.setEventManager(customEventManager);
             }).toThrow(/EventManager is already in use/);
         });
+
+        test('warns about implicit configuration when configuration was not set beforehand', () => {
+            const warningSpy = vi.fn();
+            serviceLocator.setLogger(makeMockLogger({ warning: warningSpy }));
+
+            serviceLocator.getEventManager();
+
+            expect(warningSpy).toHaveBeenCalledWith(expect.stringMatching(/implicitly set configuration/));
+        });
+
+        test('does not warn about implicit configuration when configuration was already set', () => {
+            const warningSpy = vi.fn();
+            serviceLocator.setLogger(makeMockLogger({ warning: warningSpy }));
+            serviceLocator.setConfiguration(new Configuration());
+
+            serviceLocator.getEventManager();
+
+            expect(warningSpy).not.toHaveBeenCalled();
+        });
     });
 
     describe('StorageBackend', () => {
@@ -168,6 +187,25 @@ describe('ServiceLocator', () => {
                 serviceLocator.setStorageBackend(customStorageBackend);
             }).toThrow(/StorageBackend is already in use/);
         });
+
+        test('warns about implicit configuration when configuration was not set beforehand', () => {
+            const warningSpy = vi.fn();
+            serviceLocator.setLogger(makeMockLogger({ warning: warningSpy }));
+
+            serviceLocator.getStorageBackend();
+
+            expect(warningSpy).toHaveBeenCalledWith(expect.stringMatching(/implicitly set configuration/));
+        });
+
+        test('does not warn about implicit configuration when configuration was already set', () => {
+            const warningSpy = vi.fn();
+            serviceLocator.setLogger(makeMockLogger({ warning: warningSpy }));
+            serviceLocator.setConfiguration(new Configuration());
+
+            serviceLocator.getStorageBackend();
+
+            expect(warningSpy).not.toHaveBeenCalled();
+        });
     });
 
     describe('Logger', () => {

test/core/crawlers/basic_crawler.test.ts

@@ -77,6 +77,20 @@ describe('BasicCrawler', () => {
         server.close();
     });
 
+    test('constructor eagerly resolves the configuration, avoiding a later implicit-configuration warning', () => {
+        serviceLocator.reset();
+        const warningSpy = vitest.spyOn(serviceLocator.getLogger(), 'warning');
+
+        new BasicCrawler({ requestHandler: async () => {} });
+        serviceLocator.getStorageBackend();
+
+        expect(warningSpy).not.toHaveBeenCalledWith(expect.stringMatching(/implicitly set configuration/));
+
+        // restore the shared storage backend expected by the other tests' beforeEach
+        serviceLocator.reset();
+        serviceLocator.setStorageBackend(new MemoryStorageBackend());
+    });
+
     test('does not leak sigint events', async () => {
         let count = 0;