fix table.rowfun() bugs that broke it entirely (#155)

Fix a couple internal bugs with variable names and ouptut packaging that were breaking rowfun.

Author: apjanke

CHANGES.txt

@@ -7,6 +7,7 @@ Tablicious Changelog
 * Date/time fixes
   * Add datevec() methods for duration and calendarDuration; add multi-argout form for datetime.datevec(). ([#153](https://github.com/apjanke/octave-tablicious/issues/153))
   * Add duration.hms() method.
+* Fix table.rowfun() bugs that broke it. ([#155](https://github.com/apjanke/octave-tablicious/issues/155))
 
 0.4.6 (2026-02-16)
 ------------------

inst/@table/table.m

@@ -2712,6 +2712,7 @@ function prettyprint (this)
       # Input handling
       mustBeA (func, 'function_handle');
       mustBeA (A, 'table');
+      this = A;
       validOptions = {'InputVariables', 'GroupingVariables', 'OutputFormat', ...
         'SeparateInputs', 'ExtractCellContents', 'OutputVariableNames', ...
         'NumOutputs', 'ErrorHandler'};
@@ -2729,10 +2730,10 @@ function prettyprint (this)
       if (isfield (opts, 'OutputFormat'))
         output_format = opts.OutputFormat;
       endif
-      validOutputFormats = {'table','uniform','cell'};
-      if (! ismember (outputFormat, validOutputFormats))
+      validOutputFormats = {'table', 'uniform', 'cell'};
+      if (! ismember (output_format, validOutputFormats))
         error ('table.rowfun: Invalid OutputFormat: %s. Must be one of: %s', ...
-          outputFormat, strjoin (validOutputFormats, ', '));
+          output_format, strjoin (validOutputFormats, ', '));
       endif
       errorHandler = [];
       if isfield (opts, 'ErrorHandler')
@@ -2742,7 +2743,6 @@ function prettyprint (this)
         endif
         errorHandler = opts.ErrorHandler;
       endif
-      tbl = A;
       n_out_args = [];
       if (isfield (opts, 'NumOutputs'))
         mustBeScalar (opts.NumOutputs, 'opts.NumOutputs');
@@ -2759,7 +2759,7 @@ function prettyprint (this)
         endif
         out_var_names = cell (1, n_out_args);
         for i = 1:n_out_args
-          out_var_names = sprintf ("out%d", i);
+          out_var_names{i} = sprintf ("out%d", i);
         endfor
       endif
       do_separate_inputs = true;
@@ -2828,15 +2828,15 @@ function prettyprint (this)
       # Output packaging
       switch (output_format)
         case 'table'
-          out_vars = cellfun (@(c) cat(1, c{:}), out_bufs);
+          out_vars = cellfun (@(c) cat(1, c{:}), out_bufs, 'UniformOutput', false);
           out = table (out_vars{:}, 'VariableNames', out_var_names);
           varargout = { out };
         case 'cell'
-          varargout = out_vars;
+          varargout = out_bufs;
         case 'uniform'
-          varargout = cellfun(@(c) cat(1, c{:}), out_bufs);
+          varargout = cellfun (@(c) cat(1, c{:}), out_bufs, 'UniformOutput', false);
         case 'timetable'
-          error ('timetable is not yet implemented. Sorry.');
+          error ('timetable is not yet implemented in Tablicious. Sorry.');
         otherwise
           error ('table.rowfun: Invalid OutputFormat: ''%s''', output_format);
       endswitch

inst/t/t_01_table.m

@@ -10,7 +10,6 @@
 # and then modified by Andrew Janke.
 
 if nargin < 1 || isempty (quiet);   quiet = false;  endif
-
 verbose = ! quiet;
 
 table_classes = {@table};

inst/t/t_01a_table_manipulation.m

@@ -0,0 +1,45 @@
+# Covered by the 3-clause BSD License (see LICENSES/LICENSE-MATPOWER file for details).
+#
+# Copyright (c) 1996-2022 Power Systems Engineering Research Center (PSERC)
+# Copyright (c) 2024, 2026 Andrew Janke
+
+function t_01a_table_manipulation (quiet)
+# Tests for table array manipulation functionality.
+
+if nargin < 1 || isempty (quiet);   quiet = false;  endif
+verbose = ! quiet;
+
+t_begin (6, quiet);
+
+t_01a_01_rowfun (quiet);
+
+t_end;
+
+endfunction
+
+function t_01a_01_rowfun (quiet)
+# Test rowfun().
+#
+# 6 tests.
+
+if nargin < 1 || isempty (quiet);   quiet = false;  endif
+verbose = ! quiet;
+
+t = table((1:4)', (-4:-1)', 'VariableNames', {'A', 'B'});
+
+r = rowfun(@(a,b) a+b, t, 'InputVariables', {'A', 'B'}, 'SeparateInputs', true);
+
+t_ok (isa (r, 'table'));
+t_ok (isequal (r.Properties.VariableNames, {'out1'}));
+
+r_c = rowfun(@(a,b) a+b, t, 'InputVariables', {'A', 'B'}, 'SeparateInputs', true, 'OutputFormat', 'cell');
+
+t_ok (isa (r_c, 'cell'));
+t_ok (isequal (r_c, {-3, -1, 1, 3}'));
+
+r_u = rowfun(@(a,b) a+b, t, 'InputVariables', {'A', 'B'}, 'SeparateInputs', true, 'OutputFormat', 'uniform');
+
+t_ok (isa (r_u, 'double'));
+t_is (r_u, [-3, -1, 1, 3]');
+
+endfunction