Prepare 0.1.4 update behavior

ying · ying · commit 2a33cf420a09 · 2026-05-22T19:52:56.000+08:00
diff --git a/Sources/ClipDock/ApplicationRuntime.swift b/Sources/ClipDock/ApplicationRuntime.swift
@@ -602,7 +602,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
             self?.updateCoordinator.checkForSettingsUpdate()
         }
         preferencesController.onUpdateReleaseRequested = { [weak self] release in
-            self?.updateCoordinator.presentUpdatePrompt(for: release)
+            self?.updateCoordinator.openReleasePage(release)
         }
         preferencesController.onAutomaticUpdateChecksChanged = { [weak self] isEnabled in
             self?.updateCoordinator.setAutomaticChecksEnabled(isEnabled)
diff --git a/Sources/ClipDock/PreferencesUI.swift b/Sources/ClipDock/PreferencesUI.swift
@@ -1031,7 +1031,7 @@ struct PreferencesVersionUpdatePresentation: Equatable {
             return PreferencesVersionUpdatePresentation(
                 detail: AppLocalization.format(
                     "preferences.version.updateAvailable.detail",
-                    defaultValue: "发现新版本 %@，点击查看更新提示",
+                    defaultValue: "发现新版本 %@，点击打开发布页面",
                     release.displayVersion
                 ),
                 value: AppLocalization.format(
@@ -2278,7 +2278,7 @@ private struct PreferenceRow<Accessory: View>: View {
                 .contentShape(Rectangle())
                 .help(AppLocalization.text(
                     "preferences.version.openRelease.help",
-                    defaultValue: "显示更新提示"
+                    defaultValue: "打开发布页面"
                 ))
             } else {
                 rowContent
diff --git a/Sources/ClipDock/Resources/AppInfo.plist b/Sources/ClipDock/Resources/AppInfo.plist
@@ -3,7 +3,7 @@
 <plist version="1.0">
 <dict>
     <key>CFBundleShortVersionString</key>
-    <string>0.1.2</string>
+    <string>0.1.4</string>
     <key>CFBundleVersion</key>
     <string>4</string>
 </dict>
diff --git a/Sources/ClipDock/Resources/en.lproj/Localizable.strings b/Sources/ClipDock/Resources/en.lproj/Localizable.strings
@@ -194,9 +194,9 @@
 "preferences.version.detail" = "Current app version";
 "preferences.version.format" = "Version %@ (%@)";
 "preferences.version.inline" = "Version %@";
-"preferences.version.openRelease.help" = "Show update prompt";
+"preferences.version.openRelease.help" = "Open release page";
 "preferences.version.title" = "Version";
-"preferences.version.updateAvailable.detail" = "New version %@ is available. Click to show the update prompt.";
+"preferences.version.updateAvailable.detail" = "New version %@ is available. Click to open the release page.";
 "preferences.version.updateAvailable.value" = "Update %@";
 "preferences.updateChecks.detail" = "Automatically check for new versions and notify when one is available";
 "preferences.updateChecks.title" = "Check for Updates";
diff --git a/Sources/ClipDock/Resources/ja.lproj/Localizable.strings b/Sources/ClipDock/Resources/ja.lproj/Localizable.strings
@@ -194,9 +194,9 @@
 "preferences.version.detail" = "Current app version";
 "preferences.version.format" = "Version %@ (%@)";
 "preferences.version.inline" = "Version %@";
-"preferences.version.openRelease.help" = "Show update prompt";
+"preferences.version.openRelease.help" = "Open release page";
 "preferences.version.title" = "Version";
-"preferences.version.updateAvailable.detail" = "New version %@ is available. Click to show the update prompt.";
+"preferences.version.updateAvailable.detail" = "New version %@ is available. Click to open the release page.";
 "preferences.version.updateAvailable.value" = "Update %@";
 "preferences.updateChecks.detail" = "Automatically check for new versions and notify when one is available";
 "preferences.updateChecks.title" = "Check for Updates";
diff --git a/Sources/ClipDock/Resources/ko.lproj/Localizable.strings b/Sources/ClipDock/Resources/ko.lproj/Localizable.strings
@@ -194,9 +194,9 @@
 "preferences.version.detail" = "Current app version";
 "preferences.version.format" = "Version %@ (%@)";
 "preferences.version.inline" = "Version %@";
-"preferences.version.openRelease.help" = "Show update prompt";
+"preferences.version.openRelease.help" = "Open release page";
 "preferences.version.title" = "Version";
-"preferences.version.updateAvailable.detail" = "New version %@ is available. Click to show the update prompt.";
+"preferences.version.updateAvailable.detail" = "New version %@ is available. Click to open the release page.";
 "preferences.version.updateAvailable.value" = "Update %@";
 "preferences.updateChecks.detail" = "Automatically check for new versions and notify when one is available";
 "preferences.updateChecks.title" = "Check for Updates";
diff --git a/Sources/ClipDock/Resources/zh-Hant.lproj/Localizable.strings b/Sources/ClipDock/Resources/zh-Hant.lproj/Localizable.strings
@@ -194,9 +194,9 @@
 "preferences.version.detail" = "Current app version";
 "preferences.version.format" = "Version %@ (%@)";
 "preferences.version.inline" = "Version %@";
-"preferences.version.openRelease.help" = "顯示更新提示";
+"preferences.version.openRelease.help" = "開啟發行頁面";
 "preferences.version.title" = "Version";
-"preferences.version.updateAvailable.detail" = "發現新版本 %@，點按以顯示更新提示。";
+"preferences.version.updateAvailable.detail" = "發現新版本 %@，點按以開啟發行頁面。";
 "preferences.version.updateAvailable.value" = "有更新 %@";
 "preferences.updateChecks.detail" = "自動檢查新版本，並在可用時提醒";
 "preferences.updateChecks.title" = "檢查更新";
diff --git a/Sources/ClipDock/UpdateChecker.swift b/Sources/ClipDock/UpdateChecker.swift
@@ -542,13 +542,6 @@ final class AppUpdateCoordinator {
                 skippedVersion: nil
             ) {
                 onSettingsUpdateStatusChanged?(.available(candidate))
-                handlePromptAction(
-                    promptPresenter.presentUpdatePrompt(
-                        release: candidate,
-                        currentVersion: currentVersion
-                    ),
-                    for: candidate
-                )
             } else {
                 onSettingsUpdateStatusChanged?(.upToDate)
             }
diff --git a/Tests/ClipboardPanelAppTests/AppUpdateCheckerTests.swift b/Tests/ClipboardPanelAppTests/AppUpdateCheckerTests.swift
@@ -128,14 +128,14 @@ struct AppUpdateCheckerTests {
             currentVersionText: "0.1.3 (3)"
         )
         #expect(available.detail.contains("0.2.0"))
-        #expect(available.detail.contains("更新提示"))
+        #expect(available.detail.contains("发布页面"))
         #expect(available.value == "有更新 0.2.0")
         #expect(available.isActionable)
     }
 
     @Test
     @MainActor
-    func settingsCheckReportsAvailabilityAndPromptsWithoutConsumingDailyCheck() async throws {
+    func settingsCheckReportsAvailabilityWithoutPromptingOrConsumingDailyCheck() async throws {
         let release = try makeRelease(version: "v0.2.0")
         let provider = FakeAppUpdateProvider(release: release)
         let promptPresenter = FakeAppUpdatePromptPresenter()
@@ -162,9 +162,9 @@ struct AppUpdateCheckerTests {
         #expect(statuses.first == .checking)
         #expect(statuses.last == .available(release))
         #expect(provider.requestCount == 1)
-        #expect(promptPresenter.requestCount == 1)
-        #expect(promptPresenter.requestedRelease == release)
-        #expect(promptPresenter.requestedCurrentVersion == "0.1.3")
+        #expect(promptPresenter.requestCount == 0)
+        #expect(promptPresenter.requestedRelease == nil)
+        #expect(promptPresenter.requestedCurrentVersion == nil)
         #expect(stateStore.lastCheckAttemptDate == nil)
     }
 
@@ -212,7 +212,7 @@ struct AppUpdateCheckerTests {
 
     @Test
     @MainActor
-    func settingsUpdatePromptDownloadActionOpensDownloadURL() async throws {
+    func settingsCheckReportsAvailabilityWithoutOpeningDownloadURL() async throws {
         let release = try makeRelease(version: "v0.2.0")
         let provider = FakeAppUpdateProvider(release: release)
         let promptPresenter = FakeAppUpdatePromptPresenter(action: .download)
@@ -233,12 +233,12 @@ struct AppUpdateCheckerTests {
 
         coordinator.checkForSettingsUpdate()
         await waitFor {
-            urlOpener.openedURLs == [release.downloadURL]
+            statuses.last == .available(release)
         }
 
         #expect(statuses.last == .available(release))
-        #expect(promptPresenter.requestCount == 1)
-        #expect(urlOpener.openedURLs == [release.downloadURL])
+        #expect(promptPresenter.requestCount == 0)
+        #expect(urlOpener.openedURLs.isEmpty)
     }
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -602,7 +602,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {`
`602`	`602`	`self?.updateCoordinator.checkForSettingsUpdate()`
`603`	`603`	`}`
`604`	`604`	`preferencesController.onUpdateReleaseRequested = { [weak self] release in`
`605`		`- self?.updateCoordinator.presentUpdatePrompt(for: release)`
	`605`	`+ self?.updateCoordinator.openReleasePage(release)`
`606`	`606`	`}`
`607`	`607`	`preferencesController.onAutomaticUpdateChecksChanged = { [weak self] isEnabled in`
`608`	`608`	`self?.updateCoordinator.setAutomaticChecksEnabled(isEnabled)`