chore: Integrate oxc and release configs (#896)

Author: mykola-mokhnach

.editorconfig

@@ -0,0 +1,14 @@
+# editorconfig.org
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+max_line_length = 120
+
+[*.md]
+trim_trailing_whitespace = false

.github/workflows/unit-test.yml

@@ -29,6 +29,6 @@ jobs:
     - run: npm run lint
       name: Run linter
     - run: npm run format:check
-      name: Run Prettier check
+      name: Run format check
     - run: npm run test
       name: Run unit tests

.releaserc

@@ -1,28 +1,29 @@
 import os from 'node:os';
-import {log} from './logger.js';
-import type {ADBOptions, ADBExecutable} from './types.js';
-import type {Logcat} from './logcat.js';
-import type {LogcatOpts, StringRecord} from './tools/types.js';
+
 import type {LRUCache} from 'lru-cache';
 import type {ExecError} from 'teen_process';
 
-import * as generalCommands from './tools/general-commands.js';
+import type {Logcat} from './logcat.js';
+import {log} from './logger.js';
+import * as aabUtilCommands from './tools/aab-utils.js';
 import * as manifestCommands from './tools/android-manifest.js';
-import * as systemCommands from './tools/system-calls.js';
 import * as signingCommands from './tools/apk-signing.js';
 import * as apkUtilCommands from './tools/apk-utils.js';
 import * as apksUtilCommands from './tools/apks-utils.js';
-import * as aabUtilCommands from './tools/aab-utils.js';
-import * as emuCommands from './tools/emulator-commands.js';
-import * as emuConstants from './tools/emu-constants.js';
-import * as lockManagementCommands from './tools/lockmgmt.js';
-import * as keyboardCommands from './tools/keyboard-commands.js';
+import * as appCommands from './tools/app-commands.js';
 import * as deviceSettingsCommands from './tools/device-settings.js';
+import * as emuConstants from './tools/emu-constants.js';
+import * as emuCommands from './tools/emulator-commands.js';
 import * as fsCommands from './tools/fs-commands.js';
-import * as appCommands from './tools/app-commands.js';
-import * as networkCommands from './tools/network-commands.js';
+import * as generalCommands from './tools/general-commands.js';
+import * as keyboardCommands from './tools/keyboard-commands.js';
+import * as lockManagementCommands from './tools/lockmgmt.js';
 import * as logcatCommands from './tools/logcat-commands.js';
+import * as networkCommands from './tools/network-commands.js';
 import * as processCommands from './tools/process-commands.js';
+import * as systemCommands from './tools/system-calls.js';
+import type {LogcatOpts, StringRecord} from './tools/types.js';
+import type {ADBOptions, ADBExecutable} from './types.js';
 import {
   DEFAULT_ADB_EXEC_TIMEOUT,
   cloneDeep,

eslint.config.mjs

@@ -1,24 +1,17 @@
-import {logger, util} from '@appium/support';
 import {EventEmitter} from 'node:events';
-import {SubProcess, exec} from 'teen_process';
+
+import {logger, util} from '@appium/support';
 import {LRUCache} from 'lru-cache';
+import {SubProcess, exec} from 'teen_process';
 import type {ExecError} from 'teen_process';
-import type {ADBExecutable} from './types.js';
+
 import type {LogEntry, LogcatOpts as StartCaptureOptions} from './tools/types.js';
+import type {ADBExecutable} from './types.js';
 
 const log = logger.getLogger('Logcat');
 const MAX_BUFFER_SIZE = 10000;
 const LOGCAT_PROC_STARTUP_TIMEOUT = 10000;
-const SUPPORTED_FORMATS = [
-  'brief',
-  'process',
-  'tag',
-  'thread',
-  'raw',
-  'time',
-  'threadtime',
-  'long',
-] as const;
+const SUPPORTED_FORMATS = ['brief', 'process', 'tag', 'thread', 'raw', 'time', 'threadtime', 'long'] as const;
 const SUPPORTED_PRIORITIES = ['v', 'd', 'i', 'w', 'e', 'f', 's'] as const;
 const DEFAULT_PRIORITY = 'v';
 const DEFAULT_TAG = '*';
@@ -139,10 +132,7 @@ export class Logcat extends EventEmitter {
         continue;
       }
       const [message, timestamp] = value;
-      if (
-        (this.logIndexSinceLastRequest && index > this.logIndexSinceLastRequest) ||
-        !this.logIndexSinceLastRequest
-      ) {
+      if ((this.logIndexSinceLastRequest && index > this.logIndexSinceLastRequest) || !this.logIndexSinceLastRequest) {
         recentLogIndex = index;
         result.push(toLogEntry(message, timestamp));
       }
@@ -215,15 +205,11 @@ function requireSpec(spec: string): string {
     resultTag = DEFAULT_TAG;
   }
   if (!priority) {
-    log.info(
-      `The priority value in spec '${spec}' is empty. Defaulting to Verbose (${DEFAULT_PRIORITY})`,
-    );
+    log.info(`The priority value in spec '${spec}' is empty. Defaulting to Verbose (${DEFAULT_PRIORITY})`);
     return `${resultTag}:${DEFAULT_PRIORITY}`;
   }
   if (!SUPPORTED_PRIORITIES.some((p) => priority.toLowerCase() === p.toLowerCase())) {
-    log.info(
-      `The priority value in spec '${spec}' is unknown. Supported values are: ${SUPPORTED_PRIORITIES}`,
-    );
+    log.info(`The priority value in spec '${spec}' is unknown. Supported values are: ${SUPPORTED_PRIORITIES}`);
     log.info(`Defaulting to Verbose (${DEFAULT_PRIORITY})`);
     return `${resultTag}:${DEFAULT_PRIORITY}`;
   }

lib/adb.ts

@@ -1,12 +1,14 @@
-import {log} from '../logger.js';
+import crypto from 'node:crypto';
 import path from 'node:path';
+
 import {fs, tempDir, util} from '@appium/support';
-import {LRUCache} from 'lru-cache';
 import AsyncLock from 'async-lock';
-import crypto from 'node:crypto';
+import {LRUCache} from 'lru-cache';
+
 import type {ADB} from '../adb.js';
-import type {ApkCreationOptions, StringRecord} from './types.js';
+import {log} from '../logger.js';
 import {unzipFile} from '../utils/index.js';
+import type {ApkCreationOptions, StringRecord} from './types.js';
 
 const AAB_CACHE = new LRUCache<string, string>({
   max: 10,
@@ -21,9 +23,7 @@ process.on('exit', () => {
   }
 
   const paths = [...AAB_CACHE.values()];
-  log.debug(
-    `Performing cleanup of ${paths.length} cached .aab ` + util.pluralize('package', paths.length),
-  );
+  log.debug(`Performing cleanup of ${paths.length} cached .aab ` + util.pluralize('package', paths.length));
   for (const appPath of paths) {
     try {
       // Asynchronous calls are not supported in onExit handler
@@ -45,11 +45,7 @@ process.on('exit', () => {
  * by default.
  * @throws {Error} If there was an error while creating the universal .apk
  */
-export async function extractUniversalApk(
-  this: ADB,
-  aabPath: string,
-  opts: ApkCreationOptions = {},
-): Promise<string> {
+export async function extractUniversalApk(this: ADB, aabPath: string, opts: ApkCreationOptions = {}): Promise<string> {
   if (!(await fs.exists(aabPath))) {
     throw new Error(`The file at '${aabPath}' either does not exist or is not accessible`);
   }
@@ -65,9 +61,7 @@ export async function extractUniversalApk(
       let cacheHash = aabHash;
       if (keystore) {
         if (!(await fs.exists(keystore))) {
-          throw new Error(
-            `The keystore file at '${keystore}' either does not exist ` + `or is not accessible`,
-          );
+          throw new Error(`The keystore file at '${keystore}' either does not exist or is not accessible`);
         }
         if (!keystorePassword || !keyAlias || !keyPassword) {
           throw new Error(

lib/logcat.ts

@@ -1,10 +1,12 @@
-import {exec} from 'teen_process';
-import {log} from '../logger.js';
-import {fs, zip, tempDir, util} from '@appium/support';
 import path from 'node:path';
+
+import {fs, zip, tempDir, util} from '@appium/support';
+import {exec} from 'teen_process';
+
 import type {ADB} from '../adb.js';
-import type {APKInfo, PlatformInfo, StringRecord} from './types.js';
+import {log} from '../logger.js';
 import {APKS_EXTENSION, readPackageManifest, unzipFile} from '../utils/index.js';
+import type {APKInfo, PlatformInfo, StringRecord} from './types.js';
 
 /**
  * Extract package and main activity name from application manifest.
@@ -14,10 +16,7 @@ import {APKS_EXTENSION, readPackageManifest, unzipFile} from '../utils/index.js'
  * @throws {error} If there was an error while getting the data from the given
  *                 application package.
  */
-export async function packageAndLaunchActivityFromManifest(
-  this: ADB,
-  appPath: string,
-): Promise<APKInfo> {
+export async function packageAndLaunchActivityFromManifest(this: ADB, appPath: string): Promise<APKInfo> {
   if (appPath.endsWith(APKS_EXTENSION)) {
     appPath = await this.extractBaseApk(appPath);
   }
@@ -48,10 +47,7 @@ export async function targetSdkVersionFromManifest(this: ADB, appPath: string):
 
   const {targetSdkVersion} = await readPackageManifest.bind(this)(appPath);
   if (!targetSdkVersion) {
-    throw new Error(
-      `Cannot extract targetSdkVersion of '${originalAppPath}'. Does ` +
-        `the package manifest define it?`,
-    );
+    throw new Error(`Cannot extract targetSdkVersion of '${originalAppPath}'. Does the package manifest define it?`);
   }
   return targetSdkVersion;
 }
@@ -71,9 +67,7 @@ export async function targetSdkVersionUsingPKG(
 ): Promise<number> {
   const stdout = cmdOutput || (await this.shell(['dumpsys', 'package', pkg]));
   const targetSdkVersionMatch = new RegExp(/targetSdk=([^\s\s]+)/g).exec(stdout);
-  return targetSdkVersionMatch && targetSdkVersionMatch.length >= 2
-    ? parseInt(targetSdkVersionMatch[1], 10)
-    : 0;
+  return targetSdkVersionMatch && targetSdkVersionMatch.length >= 2 ? parseInt(targetSdkVersionMatch[1], 10) : 0;
 }
 
 /**
@@ -93,9 +87,7 @@ export async function compileManifest(
 ): Promise<void> {
   const {platform, platformPath} = await getAndroidPlatformAndPath(this.sdkRoot as string);
   if (!platform || !platformPath) {
-    throw new Error(
-      'Cannot compile the manifest. The required platform does not exist (API level >= 17)',
-    );
+    throw new Error('Cannot compile the manifest. The required platform does not exist (API level >= 17)');
   }
   const resultPath = `${manifest}.apk`;
   const androidJarPath = path.resolve(platformPath, 'android.jar');
@@ -169,12 +161,7 @@ export async function compileManifest(
  * @param dstApk - Full path to the resulting package.
  *                          The file will be overridden if it already exists.
  */
-export async function insertManifest(
-  this: ADB,
-  manifest: string,
-  srcApk: string,
-  dstApk: string,
-): Promise<void> {
+export async function insertManifest(this: ADB, manifest: string, srcApk: string, dstApk: string): Promise<void> {
   log.debug(`Inserting manifest '${manifest}', src: '${srcApk}', dst: '${dstApk}'`);
   await zip.assertValidZip(srcApk);
   await unzipFile(`${manifest}.apk`);
@@ -221,10 +208,7 @@ export async function insertManifest(
  * @param appPath - The full path to .apk(s) package.
  * @return True if the manifest requires Internet access permission.
  */
-export async function hasInternetPermissionFromManifest(
-  this: ADB,
-  appPath: string,
-): Promise<boolean> {
+export async function hasInternetPermissionFromManifest(this: ADB, appPath: string): Promise<boolean> {
   log.debug(`Checking if '${appPath}' requires internet access permission in the manifest`);
   if (appPath.endsWith(APKS_EXTENSION)) {
     appPath = await this.extractBaseApk(appPath);