Skip to content

Commit 7491d32

Browse files
authored
fix(server): pin maildev/maildev test container to 2.2.1 (#41956)
## Description `SmtpPluginTest` uses the `maildev/maildev` Testcontainers image without a tag, which resolves to `:latest`. Maildev recently published a new RC and tagged it `latest`, and it's broken in our test setup: the container's internal exec-based readiness check fails (`/bin/sh: /bin/bash: not found`, exit 137), and the test connects to the mapped SMTP port before the listener is actually ready, causing intermittent connection failures. This pins both `GenericContainer` instances in `SmtpPluginTest` to `maildev/maildev:2.2.1`, the last known-good tag (see [tags on Docker Hub](https://hub.docker.com/r/maildev/maildev/tags)), to stop tracking `latest` and avoid future silent breaks from upstream RCs. ### Context Observed as a repeated CI failure on an EE release-promotion PR (`server-unit-tests` shard 5), reproduced on both the initial run and a retry. ## Test plan - [ ] `server-unit-tests` (specifically `SmtpPluginTest`) passes reliably in CI <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Updated SMTP test containers to use a pinned MailDev image version for more consistent test execution. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 20b5027 commit 7491d32

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

app/server/appsmith-plugins/smtpPlugin/src/test/java/com/external/plugins/SmtpPluginTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ public class SmtpPluginTest {
5454
private static Long port = 25L;
5555

5656
@Container
57-
public static final GenericContainer smtp = new GenericContainer(DockerImageName.parse("maildev/maildev"))
57+
public static final GenericContainer smtp = new GenericContainer(DockerImageName.parse("maildev/maildev:2.2.1"))
5858
.withExposedPorts(25)
5959
.withCommand("bin/maildev --base-pathname /maildev --incoming-user " + username + " --incoming-pass "
6060
+ password + " -s 25");
6161

6262
@Container
6363
public static final GenericContainer smtpWithoutAuth = new GenericContainer(
64-
DockerImageName.parse("maildev/maildev"))
64+
DockerImageName.parse("maildev/maildev:2.2.1"))
6565
.withExposedPorts(1025)
6666
.withCommand("bin/maildev --base-pathname /maildev --smtp-port 1025 --incoming-user '' --incoming-pass ''");
6767

0 commit comments

Comments
 (0)