Commit 75847cf
fix: keep form signup toggle label static (#42167)
## Description
In **Admin Settings → Authentication → Form login**, the signup toggle
(`isSignupDisabled`) rendered its label from the current value: "Allow
only invited users to signup" when signup is disabled, "Allow all users
to signup" when enabled. Because the label restated the current state,
toggling the switch appeared to change the option itself — a customer
looking for the "invited users" option couldn't find it while it was
enabled, and open signup kept adding unintended members (and paid seats)
to their org.
This PR makes the label static — **"Allow all users to signup"** — so it
describes what the setting does: switch ON = anyone can sign up, switch
OFF = only invited users can sign up. This matches the static-label
pattern of the sibling toggles on the same page ("Enable form login",
"Enable email verification") and keeps the accessible name of the switch
stable across activation.
Behavior of the setting itself is unchanged; this is label-only.
### Call sites checked
- `toggleText` is only consumed by `FieldToggleWithToggleText` in
`app/client/src/pages/AdminSettings/FormGroup/Toggle.tsx`;
`isSignupDisabled` was the only setting supplying a value-dependent one.
- No Cypress spec or locator references either label string (the signup
toggle locator is testid-based: `[data-testid='isSignupDisabled']`).
- EE imports `FormAuth` from `ce/` with no override, so this CE-only
change flows to EE via the hourly sync (verified it applies cleanly).
### Tests
- New unit test
`app/client/src/ce/pages/AdminSettings/config/authentication.test.tsx`:
asserts the label is state-independent and pins the exact wording.
Verified red against the pre-fix source, green after.
- Full `src/pages/AdminSettings` jest scope passes (13 suites, 39
tests).
Fixes https://linear.app/appsmith/issue/APP-15855
## Automation
/ok-to-test tags="@tag.All"
### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/33033481965>
> Commit: b7d0192
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=33033481965&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Thu, 27 Aug 2026 03:33:10 UTC
<!-- end of auto-generated comment: Cypress test results -->
## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Updated the signup setting label to consistently display “Allow all
users to signup,” regardless of the toggle state.
* **Tests**
* Added coverage to verify the signup setting label remains consistent
when toggled.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>1 parent 4a70a0f commit 75847cf
2 files changed
Lines changed: 22 additions & 4 deletions
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
| 64 | + | |
68 | 65 | | |
69 | 66 | | |
70 | 67 | | |
| |||
0 commit comments