Skip to content

Commit d18802b

Browse files
authored
fix: increase api timeout for client class for consolidated api to 60 seconds from 20 (#41591)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/22662866220> > Commit: 1f6aead > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Wed, 04 Mar 2026 09:18:28 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced application stability by implementing timeout protection for consolidated page load operations. View and edit page load API requests now enforce a 60-second timeout limit, preventing indefinite request hangs and ensuring improved responsiveness when retrieving page data. This helps maintain a consistently smooth user experience during data loading operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 79c8e72 commit d18802b

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { api } from "api/core";
2+
import { CONSOLIDATED_API_TIMEOUT_MS } from "ee/constants/ApiConstants";
23
import type { InitConsolidatedApi } from "sagas/InitSagas";
34
import type { ConsolidatedApiParams } from "./types";
45
import { ConsolidatedApiUtils } from "./url";
@@ -8,13 +9,17 @@ export const getConsolidatedPageLoadDataView = async (
89
) => {
910
const viewUrl = ConsolidatedApiUtils.getViewUrl(params);
1011

11-
return api.get<InitConsolidatedApi>(viewUrl);
12+
return api.get<InitConsolidatedApi>(viewUrl, {
13+
timeout: CONSOLIDATED_API_TIMEOUT_MS,
14+
});
1215
};
1316

1417
export const getConsolidatedPageLoadDataEdit = async (
1518
params: ConsolidatedApiParams,
1619
) => {
1720
const editUrl = ConsolidatedApiUtils.getEditUrl(params);
1821

19-
return api.get<InitConsolidatedApi>(editUrl);
22+
return api.get<InitConsolidatedApi>(editUrl, {
23+
timeout: CONSOLIDATED_API_TIMEOUT_MS,
24+
});
2025
};

app/client/src/ce/constants/ApiConstants.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export const DEFAULT_EXECUTE_ACTION_TIMEOUT_MS = 15000;
88
export const DEFAULT_TEST_DATA_SOURCE_TIMEOUT_MS = 30000;
99
export const DEFAULT_APPSMITH_AI_QUERY_TIMEOUT_MS = 60000;
1010
export const FILE_UPLOAD_TRIGGER_TIMEOUT_MS = 60000;
11+
export const CONSOLIDATED_API_TIMEOUT_MS = 60000;
1112

1213
export const DEFAULT_AXIOS_CONFIG: CreateAxiosDefaults = {
1314
baseURL: "/api/",

0 commit comments

Comments
 (0)