Fix CI failure reporting and pin MCP builds to the approved commit - #42197
Fix CI failure reporting and pin MCP builds to the approved commit#42197lokiee0 wants to merge 1 commit into
Conversation
…nput for mcp-build
|
Thanks for contributing to Appsmith! Credential-free formatting, lint, type, and unit checks will run after GitHub's workflow approval. An Appsmith maintainer will start privileged integration tests or a deploy preview when needed. No action is required from you while this PR has the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe workflows add an optional immutable checkout reference for MCP builds. The caller passes the merge commit SHA. Reporting jobs now install Node.js 24 directly instead of reading the version from a checked-out package file. ChangesWorkflow build integrity
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The workflow updates pin checkout commits for MCP builds and configure Node directly in checkout-free reporting jobs. No current merge-readiness risk remains. Sequence Diagram(s)sequenceDiagram
participant buildClientServer as build-client-server.yml
participant mcpBuild as mcp-build.yml
participant checkout as actions/checkout
buildClientServer->>mcpBuild: Pass merge_sha as checkout-ref
mcpBuild->>checkout: Checkout approved checkout-ref SHA
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the motivation, implementation, and validation, but it does not follow the required template. It omits the issue reference, Testing section with a validation selection, and Communication section.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Cypress failure-reporting jobs referenced app/client/package.json without checking out the repository, causing Node setup to fail before reporting test failures. All five affected jobs now specify Node 24 directly.
The MCP workflow now accepts checkout-ref, and the approved CI pipeline passes its verified merge SHA. This keeps MCP on the same commit as the other build components if the PR changes after approval.
Validation:
Summary by CodeRabbit