Skip to content

Fix CI failure reporting and pin MCP builds to the approved commit - #42197

Open
lokiee0 wants to merge 1 commit into
appsmithorg:releasefrom
lokiee0:fix/ci-pipeline
Open

Fix CI failure reporting and pin MCP builds to the approved commit#42197
lokiee0 wants to merge 1 commit into
appsmithorg:releasefrom
lokiee0:fix/ci-pipeline

Conversation

@lokiee0

@lokiee0 lokiee0 commented Sep 7, 2026

Copy link
Copy Markdown

Cypress failure-reporting jobs referenced app/client/package.json without checking out the repository, causing Node setup to fail before reporting test failures. All five affected jobs now specify Node 24 directly.
The MCP workflow now accepts checkout-ref, and the approved CI pipeline passes its verified merge SHA. This keeps MCP on the same commit as the other build components if the PR changes after approval.
Validation:

  • Parsed all 50 workflow YAML files.
  • Checked eight MCP checkout combinations.
  • Verified all five build jobs receive the approved merge SHA.
  • Passed git diff --check.

Summary by CodeRabbit

  • Chores
    • Build and reporting workflows now use Node.js 24 consistently, improving predictability across CI runs.
    • Builds can now check out an explicitly approved commit, helping ensure external pull request builds use the intended source revision.
    • Build jobs now pass the selected commit revision consistently through the workflow.

@lokiee0
lokiee0 requested a review from a team as a code owner September 7, 2026 10:52
@github-actions github-actions Bot added awaiting-maintainer The next action on this pull request belongs to an Appsmith maintainer external-contribution Pull request submitted from outside the Appsmith repository labels Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Thanks for contributing to Appsmith!

Credential-free formatting, lint, type, and unit checks will run after GitHub's workflow approval. An Appsmith maintainer will start privileged integration tests or a deploy preview when needed.

No action is required from you while this PR has the awaiting-maintainer label.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 42acd5d9-ed3b-4002-b8f4-39948805d007

📥 Commits

Reviewing files that changed from the base of the PR and between b3f9a68 and b836c4f.

📒 Files selected for processing (3)
  • .github/workflows/build-client-server-count.yml
  • .github/workflows/build-client-server.yml
  • .github/workflows/mcp-build.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The workflows add an optional immutable checkout reference for MCP builds. The caller passes the merge commit SHA. Reporting jobs now install Node.js 24 directly instead of reading the version from a checked-out package file.

Changes

Workflow build integrity

Layer / File(s) Summary
Approved commit checkout
.github/workflows/mcp-build.yml, .github/workflows/build-client-server.yml
The reusable workflow accepts checkout-ref and checks out that SHA when provided. The client-server workflow passes the merge commit SHA to mcp-build.
Pinned reporting Node version
.github/workflows/build-client-server.yml, .github/workflows/build-client-server-count.yml
Reporting jobs use node-version: "24" instead of node-version-file. The existing Docker-image failure check remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b836c

The workflow updates pin checkout commits for MCP builds and configure Node directly in checkout-free reporting jobs. No current merge-readiness risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant buildClientServer as build-client-server.yml
  participant mcpBuild as mcp-build.yml
  participant checkout as actions/checkout
  buildClientServer->>mcpBuild: Pass merge_sha as checkout-ref
  mcpBuild->>checkout: Checkout approved checkout-ref SHA
Loading

Suggested reviewers: sondermanish, subrata71, tomjose92

Poem

A commit takes the guarded lane
Node twenty-four runs plain
Builds now follow a pinned trace
Checkouts keep their ordered place
Reporting stays in tune

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the motivation, implementation, and validation, but it does not follow the required template. It omits the issue reference, Testing section with a validation selection, and Co… Add the required issue reference, use the Testing section, select the applicable validation option such as Not applicable, and complete the Communication section with Yes or No.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both primary changes: fixing CI failure reporting and pinning MCP builds to the approved commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the motivation, implementation, and validation, but it does not follow the required template. It omits the issue reference, Testing section with a validation selection, and Communication section.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-maintainer The next action on this pull request belongs to an Appsmith maintainer external-contribution Pull request submitted from outside the Appsmith repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant