chore: Removed mcp server url settings from admin settings - #42208
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. WalkthroughThe change removes MCP data and server URL settings, keeps ChangesMCP configuration and restart flow
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to MCP administration is reduced to the enabled switch, with single-organization changes using the Save and Restart flow. The updated configuration and persistence paths are covered without an identified merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant AdminSettings
participant OrganizationService
participant updateOrganizationConfigSaga
participant ServerRestartPoll
AdminSettings->>OrganizationService: update MCP configuration with needsRestart
OrganizationService-->>updateOrganizationConfigSaga: return successful update
updateOrganizationConfigSaga->>ServerRestartPoll: dispatch RESTART_SERVER_POLL
ServerRestartPoll-->>AdminSettings: track server restart
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
One MCP switch stands bright and clear Comment |
Description
Fixes https://linear.app/appsmith/issue/APP-15928/mcp-settings-toggle-should-require-a-restart-for-mcp-server-to-source
Automation
/ok-to-test tags="@tag.All"
Testing
Note
How CI runs on fork PRs — no action needed from you.
/approve-ci, and/build-deploy-previewwhen hands-on testing is needed. Approval is pinned to one commit — pushing again requires fresh approval.The
awaiting-maintainer/awaiting-contributorlabels show whose turn it is. You do not needok-to-testor any slash command. Full detail: Pull request check states.Select the validation relevant to this change:
Suggested Cypress tags or specs:
Communication
Should the DevRel and Marketing teams inform users about this change?
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/34195617186
Commit: 584a55c
Cypress dashboard.
Tags:
@tag.AllSpec:
Tue, 08 Sep 2026 07:42:19 UTC
Summary by CodeRabbit
New Features
Bug Fixes
Tests