fix(test): prevent Email_settings stale getAllWorkspaces intercept

[subrata71]

Description

Email_settings_Spec failed all Cypress retries in isolation (run 34177523488). Tests 4 and 6 visited /applications while logged out, then LoginFromAPI waited on @getAllWorkspaces and consumed a 401 body with no responseMeta. processNetworkStatus then threw Cannot read properties of undefined (reading 'status'). CypressReload() on that path also mixed cy.reload() with cy.log() from the global fail handler.

Test 5 already used logout → login page → LoginFromAPI → /applications and passed every retry. This PR matches that order, drops the redundant reloads, and logs test 2 in explicitly. Prior HTML-body wait (#41893) did not cover this.

Fixes https://linear.app/appsmith/issue/APP-15931

Testing

• Client unit tests
• Server unit tests
• Cypress
• Playwright
• Deploy preview
• Not applicable

Suggested Cypress tags or specs:
@tag.Email

Automation

/ok-to-test tags="@tag.Email"

🔍 Cypress test results

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/34225280782
Commit: e90b107
Cypress dashboard.
Tags: @tag.Email
Spec:

---

Tue, 08 Sep 2026 12:37:23 UTC

Summary by CodeRabbit

• Tests
  • Streamlined automated coverage for admin email settings.
  • Removed redundant navigation and page reload steps from several test scenarios.
  • Updated login and navigation sequencing to make test execution more direct and reliable.

[linear-code]

APP-15931

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0add8d01-c73e-4da8-b457-e19ca3d5fe28

📥 Commits

Reviewing files that changed from the base of the PR and between f714550 and e90b107.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Email_settings_Spec.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

Walkthrough

The email settings Cypress tests remove redundant application-page visits and reloads. Test 2 uses direct API login. Test 6 navigates to the applications page after login.

Changes

Email settings regression tests

Layer / File(s)	Summary
Simplify test navigation app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Email_settings_Spec.ts	Tests 2, 4, 5, and 6 remove redundant application-page navigation and reload calls. Test 2 uses direct API login. Test 6 navigates after login.

Priority: ⬇️ Low — Defer this narrow Cypress test fix because it only stabilizes the Email settings regression spec without changing product behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to e90b1

Email settings regression tests now authenticate before application navigation and remove redundant reloads, addressing the stale intercept failure path without changing product behavior. No current merge-blocking risk remains.

Suggested reviewers: wyattwalter

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test fix and the stale getAllWorkspaces intercept that caused the Email_settings failures.
Description check	✅ Passed	The description explains the failure, root cause, implemented changes, issue reference, Cypress validation, test tag, and communication decision. The required sections are present and sufficiently com…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/app-15931

---

_{Fewer visits cross the test flight
Direct login starts the night
Reloads fade from view
The email checks stay true
Clean paths guide the suite just right}

_{Comment @coderabbitai help to get the list of available commands.}

[subrata71]

/ci-test-limit-count run_count=3 specs_to_run=cypress/e2e/Regression/ClientSide/AdminSettings/Email_settings_Spec.ts

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/34226849613.
Cypress dashboard
PR: #42211 .

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/34226849613.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 18 Total Passed: 12 Total Failed: 1 Total Skipped: 5 *****************************