refactor: share license file name set via pkg/licensing

Author: nikpivkin

pkg/dependency/parser/java/jar/parse.go

@@ -23,17 +23,10 @@ import (
 	ftypes "github.com/aquasecurity/trivy/pkg/fanal/types"
 	"github.com/aquasecurity/trivy/pkg/licensing"
 	"github.com/aquasecurity/trivy/pkg/log"
-	"github.com/aquasecurity/trivy/pkg/set"
 	xio "github.com/aquasecurity/trivy/pkg/x/io"
 	xos "github.com/aquasecurity/trivy/pkg/x/os"
 )
 
-// licenseFileStems are the base names (without extension) of files treated as
-// license files inside a jar, matched case-insensitively. It mirrors the set used
-// by the standalone license file analyzer (its acceptedFileNames), but matching is
-// done on the stem so common variants like LICENSE.txt are also recognized.
-var licenseFileStems = set.NewCaseInsensitive("license", "licence", "copyright")
-
 var (
 	jarFileRegEx = regexp.MustCompile(`^([a-zA-Z0-9\._-]*[^-*])-(\d\S*(?:-SNAPSHOT)?).jar$`)
 )
@@ -494,7 +487,7 @@ func isJarLicenseFile(name string) bool {
 		return false // e.g. license.jar is a nested archive, not a license file
 	}
 	stem := strings.TrimSuffix(base, path.Ext(base))
-	return licenseFileStems.Contains(stem)
+	return licensing.LicenseFileNames.Contains(stem)
 }
 
 // classifyPackedLicense classifies a LICENSE file packed in a jar and returns the

pkg/fanal/analyzer/licensing/license.go

@@ -69,12 +69,6 @@ var (
 		".vue",
 		".zsh",
 	)
-
-	acceptedFileNames = set.NewCaseInsensitive(
-		"license",
-		"licence",
-		"copyright",
-	)
 )
 
 func init() {
@@ -126,7 +120,7 @@ func (a *licenseFileAnalyzer) Required(filePath string, _ os.FileInfo) bool {
 		return true
 	}
 
-	return acceptedFileNames.Contains(filepath.Base(filePath))
+	return licensing.LicenseFileNames.Contains(filepath.Base(filePath))
 }
 
 func isHumanReadable(content xio.ReadSeekerAt, fileSize int64) (bool, error) {

pkg/licensing/classifier.go

@@ -15,6 +15,10 @@ import (
 	"github.com/aquasecurity/trivy/pkg/set"
 )
 
+// LicenseFileNames are the base names (case-insensitive, without extension) of files
+// commonly used to hold a license, e.g. LICENSE, LICENCE, COPYRIGHT.
+var LicenseFileNames = set.NewCaseInsensitive("license", "licence", "copyright")
+
 var (
 	cf             *classifier.Classifier
 	classifierOnce sync.Once