refactor(rpc): remove unused Insecure field from ServiceOption

[knqyf263]

Description

The Insecure field in ServiceOption struct (pkg/rpc/client/client.go) is defined but never used.

https://github.com/aquasecurity/trivy/blob/749f72680bbd42295688ae00c6f3d14b04addb09/pkg/rpc/client/client.go#L26-L31

type ServiceOption struct {
    RemoteURL     string
    Insecure      bool       // <- This field is unused
    CustomHeaders http.Header
    PathPrefix    string
}

Background

The Insecure option is already configured at the transport level via xhttp.SetDefaultTransport() in pkg/commands/artifact/run.go:

xhttp.SetDefaultTransport(xhttp.NewTransport(xhttp.Options{
    Insecure:  cliOptions.Insecure,
    CACerts:   cliOptions.CACerts,
    Timeout:   cliOptions.Timeout,
    TraceHTTP: cliOptions.TraceHTTP,
}))

Since xhttp.Client() uses the default transport, the Insecure setting is automatically applied. Therefore, ServiceOption.Insecure is redundant and can be safely removed.

Proposed Solution

1. Remove the Insecure field from ServiceOption struct in pkg/rpc/client/client.go
2. Update any code that sets this field (if any)

References

• Discussion: feat(server): include server version info in JSON output for client/server mode #10075 (comment)

[BrajamohanDas-afk]

@knqyf263 Hello, I would like to work on this issue