Commit 95a57c6
feat(raft): implement snapshot creation and restore (#255)
* feat(raft): implement snapshot creation and restore
Implement core snapshot functionality to establish checkpoint → tar → restore
* fix
* feat(raft): implement snapshot install hot-swapping with ArcSwap
Solves P0/P1 issues from PR #255 review:
- P0: Active DB handle problem - use placeholder Storage swap to release
old Storage before restoring checkpoint, avoiding RocksDB lock conflict
- P0: Metadata validation - validate checkpoint metadata against SnapshotMeta
- P1: Windows compatibility - atomic file replacement with cfg conditionals
Key changes:
- Add ArcSwap pattern: GlobalStorage wraps ArcSwap<Storage> for hot-swapping
- StorageServerPauseController for coordinating pause during snapshot install
- KiwiStateMachine.swap() atomically switches to new Storage after install
- PauseController trait integration between StorageServer and RaftNode
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fmt
* fix(storage): share ArcSwap across all components and deduplicate drop/close logic
Address PR review comments:
1. GlobalStorage now uses Arc<ArcSwap<Storage>> so all clones share the same
ArcSwap instance. Previously, clone() created a new ArcSwap, causing
StorageServer and Raft to use separate containers - swap() in StateMachine
was invisible to StorageServer.
2. Extract release_resources() private method to deduplicate cleanup logic
between Drop::drop() and close(). Both now call this shared method,
eliminating code redundancy.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>1 parent 60cd512 commit 95a57c6
22 files changed
Lines changed: 1602 additions & 97 deletions
File tree
- src
- common/runtime
- engine/src
- raft
- src
- tests
- server
- src
- storage
- src
- tests
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
66 | | - | |
| 68 | + | |
67 | 69 | | |
0 commit comments