Closed
Conversation
Contributor
Author
|
Closing in favor of #3706, which is based cleanly on main and contains only the Bedrock tool-name fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Bedrock Converse requests that fail when MCP tool names exceed Bedrock's provider-side tool name limit.
Root Cause
Bedrock validates
toolConfig.tools[*].toolSpec.namebefore model execution and rejects names longer than its limit. Some fully qualified MCP tool names can exceed that provider limit even though the same tool works through other providers.Validation
ARCHESTRA_DATABASE_URL=postgres://test:test@localhost:5432/test pnpm --filter @backend exec vitest run src/routes/proxy/adapterV2/bedrock.test.tspnpm --filter @backend type-checkpnpm --filter @backend exec biome check src/routes/proxy/adapterV2/bedrock.ts src/routes/proxy/adapterV2/bedrock.test.ts src/types/llm-providers/bedrock/index.ts