Skip to content

Commit 64d0a7e

Browse files
authored
ci: resolve deprecation warnings and Go cache failure (#393)
## Summary - **`app-id` → `client-id`** — Replace deprecated `app-id` input with `client-id` in all 3 `actions/create-github-app-token` steps in `release.yml` (same secret, just the input name) - **Node.js 24 opt-in** — Add `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true` to `release.yml` so `TrigenSoftware/simple-release-action` (stuck on `node20`) runs on Node 24 ahead of the June 16 forced migration - **Go cache fix** — Add `cache-dependency-path: shims/go/go.sum` to `actions/setup-go` in `code-pull-request.yml` so it finds the dependency file in the shim subdirectory instead of failing with "Dependencies file is not found" ## Test plan - [ ] Merge and verify the Release workflow runs without `app-id` deprecation warnings - [ ] Verify the `simple-release-action` steps succeed under Node.js 24 - [ ] Verify the "Shim Tests (go)" job no longer shows a cache restore warning Signed-off-by: Rhuan Barreto <rhuan@barreto.work>
1 parent 9edabde commit 64d0a7e

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/code-pull-request.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ jobs:
135135
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
136136
with:
137137
go-version: "1.21"
138+
cache-dependency-path: shims/go/go.sum
138139
- name: Test Go shim
139140
if: matrix.shim == 'go'
140141
working-directory: shims/go

.github/workflows/release.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ permissions: {}
1515

1616
env:
1717
ARCHGATE_TELEMETRY: "0"
18+
# Opt into Node.js 24 for all actions — TrigenSoftware/simple-release-action
19+
# still declares `using: node20` and GitHub will force Node 24 on June 16, 2026.
20+
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
1821

1922
jobs:
2023
check:
@@ -31,7 +34,7 @@ jobs:
3134
id: generate_token
3235
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3
3336
with:
34-
app-id: ${{ secrets.GH_APP_APP_ID }}
37+
client-id: ${{ secrets.GH_APP_APP_ID }}
3538
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
3639
- name: Checkout code
3740
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
@@ -78,7 +81,7 @@ jobs:
7881
id: generate_token
7982
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3
8083
with:
81-
app-id: ${{ secrets.GH_APP_APP_ID }}
84+
client-id: ${{ secrets.GH_APP_APP_ID }}
8285
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
8386
- name: Checkout code
8487
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
@@ -131,7 +134,7 @@ jobs:
131134
id: generate_token
132135
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3
133136
with:
134-
app-id: ${{ secrets.GH_APP_APP_ID }}
137+
client-id: ${{ secrets.GH_APP_APP_ID }}
135138
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
136139
- name: Checkout code
137140
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

0 commit comments

Comments
 (0)