Commit 6b0091a
committed
refactor(comments): exempt TSDoc tags, drop test carve-outs, strip obvious comments
GEN-004 was measuring the wrong thing: a flat prose bound made TSDoc tags
compete with the summary for budget, so an earlier sweep dissolved 8 @param
tags and an @example into prose. Three changes fix that.
1. Structured documentation is exempt. A structural TSDoc tag (@param,
@returns, @throws, @example, @see, @typeparam, ...) opens a section that
does not count toward the 5-line bound — its length tracks the API
surface, not narrative. Prose containers (@remarks, @description,
@notes, @todo, @fixme) still count, so relabelling narrative cannot buy
budget. Implemented identically in both layers.
2. No directory-level carve-outs. The tests/** size exemption and the
tests/fixtures/** full exemption are gone from .oxlintrc.json and the
companion rules file; the ADR now records that any future exemption
belongs in the ADR, not in lint config. Removing them surfaced only 10
blocks and zero narration, because the tag exemption covers the reason
test comments legitimately grow.
3. Obvious comments removed. A 12-agent sweep over 238 files deleted 248
comments that restate the code they sit above, keeping every comment
carrying a why, an invariant, a footgun, a security property, or a
pointer. Verified by diffing ADR references, issue links, and TSDoc tags
per file: no net loss anywhere except duplicate copies of one upstream
bug link.
Also restores the tags the earlier sweep dissolved, syncs rules-shim.ts
(the user-facing rules.d.ts) with formats/rules.ts, and rescues the CLI
perf baselines into agent memory.
Signed-off-by: Rhuan Barreto <rhuan@barreto.work>1 parent f2c9a1c commit 6b0091a
135 files changed
Lines changed: 642 additions & 776 deletions
File tree
- .archgate
- adrs
- lint
- .claude/agent-memory/archgate-developer
- lint
- scripts
- src
- commands
- adr
- plugin
- engine
- formats
- helpers
- tests
- commands
- adr
- plugin
- session-context
- engine
- formats
- helpers
- integration
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
30 | 28 | | |
31 | 29 | | |
32 | 30 | | |
| |||
44 | 42 | | |
45 | 43 | | |
46 | 44 | | |
47 | | - | |
48 | 45 | | |
49 | 46 | | |
50 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
| 14 | + | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
151 | 150 | | |
152 | 151 | | |
153 | 152 | | |
| |||
229 | 228 | | |
230 | 229 | | |
231 | 230 | | |
232 | | - | |
233 | 231 | | |
234 | 232 | | |
235 | 233 | | |
236 | 234 | | |
237 | 235 | | |
238 | 236 | | |
239 | 237 | | |
240 | | - | |
241 | 238 | | |
242 | 239 | | |
243 | 240 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
| |||
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | 19 | | |
21 | 20 | | |
22 | | - | |
23 | 21 | | |
24 | 22 | | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
28 | | - | |
29 | 26 | | |
30 | 27 | | |
31 | 28 | | |
| |||
35 | 32 | | |
36 | 33 | | |
37 | 34 | | |
38 | | - | |
39 | 35 | | |
40 | 36 | | |
41 | 37 | | |
| |||
44 | 40 | | |
45 | 41 | | |
46 | 42 | | |
47 | | - | |
48 | 43 | | |
49 | 44 | | |
50 | 45 | | |
| |||
68 | 63 | | |
69 | 64 | | |
70 | 65 | | |
71 | | - | |
72 | 66 | | |
73 | 67 | | |
74 | 68 | | |
| |||
85 | 79 | | |
86 | 80 | | |
87 | 81 | | |
88 | | - | |
89 | 82 | | |
90 | 83 | | |
91 | 84 | | |
| |||
94 | 87 | | |
95 | 88 | | |
96 | 89 | | |
97 | | - | |
98 | 90 | | |
99 | 91 | | |
100 | 92 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
| 75 | + | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | 45 | | |
47 | 46 | | |
48 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
56 | | - | |
57 | 55 | | |
58 | 56 | | |
59 | 57 | | |
| |||
128 | 126 | | |
129 | 127 | | |
130 | 128 | | |
131 | | - | |
132 | 129 | | |
133 | 130 | | |
134 | 131 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
| |||
0 commit comments