Custom Storybook version feature won't work for v8

[wojciechczerniak]

Defining custom Storybook version done in #107 is capped at Storybook v8 due to breaking change in Storybook CLI.

It's mentioned in the PR, but I've done some digging and here's where it failed. Might not be the only blocker

Code:

blast/package.json

Line 7 in 79c8568

"storybook": "concurrently --i -c \"red,blue,yellow\" -n storybook,watch-components,watch-data \"storybook dev --quiet -c $STORYBOOK_CONFIG_PATH -s $STORYBOOK_STATIC_PATH -p $STORYBOOK_PORT\" \"npm run watch-components\" \"npm run watch-data\"",

Issue:

- -s $STORYBOOK_STATIC_PATH

Reference:

With the release of Storybook 8, the -s CLI flag was removed. We recommend using the static directory instead if you need to serve static files.

Source:

https://storybook.js.org/docs/8/api/cli-options

[mrtimbrook]

Thanks for this. I'm going to find some time in the coming weeks to look into where the gaps are that prevent us from supporting newer versions of Storybook.

[wojciechczerniak]

That may be a rabbit hole with so many versions ahead. If I may suggest, Blast is using server-webpack5 internally, and does a great job processing Blade into JSON configs. IMO that should be the main focus of Blast.

I would prefer a command artisan blast:watch to run just the Blast watcher for Blade, and leave the Storybook configuration to me. Maybe a better configuration for output path. Endpoint url and path is all we need. As long as the JSON format won't change, all Storybook versions should work.

You don't have to remove storybook, both approaches can work next to each other. It can be done without breaking change. Although, less moving parts, the easier to maintain the project and focus on stories syntax. Which btw works great.