Skip to content

Commit 2bf0783

Browse files
committed
chore: improve my_scenes apis more with sets
1 parent a73eff4 commit 2bf0783

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

users/views.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -569,8 +569,10 @@ def get_my_edit_namespaces(user, version):
569569
existing_names.add(p_ns)
570570

571571
# count persisted
572+
all_names = [ns["name"] for ns in ns_out]
573+
existing_users = set(User.objects.filter(username__in=all_names).values_list("username", flat=True))
572574
for ns in ns_out:
573-
ns["account"] = User.objects.filter(username=ns["name"]).exists()
575+
ns["account"] = ns["name"] in existing_users
574576

575577
return sorted(ns_out, key=itemgetter("name"))
576578

@@ -635,8 +637,9 @@ def get_my_edit_scenes(user, version):
635637
existing_names.add(p_scene)
636638
if user.is_staff: # admin/staff
637639
# count persisted
640+
p_scenes_set = set(p_scenes)
638641
for sc in sc_out:
639-
sc["persisted"] = sc["name"] in p_scenes
642+
sc["persisted"] = sc["name"] in p_scenes_set
640643

641644
return sorted(sc_out, key=itemgetter("name"))
642645

0 commit comments

Comments
 (0)