Describe the bug
Opposed to what is described in the official docs about argo_events_action_retries_failed_total metric, when the sensor does not have retryStrategy specified this metric does not get incremented.
To Reproduce
Steps to reproduce the behavior:
- Create a sensor without retryStrategy.
- Simulate action failure by specifying erroneous job template for k8s trigger (e.g.
name not specified`).
- Trigger the event for the sensor and observe the metric values
Expected behavior
Currently argo_events_action_failed_total is incremented, but not argo_events_action_retries_failed_total.
The expected behavior is to have both metrics to be incremented.
Environment (please complete the following information):
- Kubernetes:
v1.31.12
- Argo Events:
v1.9.6
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
Describe the bug
Opposed to what is described in the official docs about
argo_events_action_retries_failed_totalmetric, when the sensor does not haveretryStrategyspecified this metric does not get incremented.To Reproduce
Steps to reproduce the behavior:
namenot specified`).Expected behavior
Currently
argo_events_action_failed_totalis incremented, but notargo_events_action_retries_failed_total.The expected behavior is to have both metrics to be incremented.
Environment (please complete the following information):
v1.31.12v1.9.6Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.