Getting "last second of tomorrow" in 0.10

[injust]

In 0.9, this is how I wrote "the last second of tomorrow, in this given time zone":

ZonedDateTime.now(TIME_ZONE).start_of_day() + days(2) - seconds(1)

Going through 0.10 migration, I ended up with this (which seems a bit harder to read):

ZonedDateTime.now(TIME_ZONE).start_of_day().add(ItemizedDelta(days=2, seconds=-1))

I was wondering if there might be a clearer way of writing this?

[ariebovenberg]

Hi @injust thanks for posting.

The cleanest way to do this would be:

ZonedDateTime.now(TZ).start_of_day().add(days=1, seconds=-1)

Note that round could be used too, but not if the time is exactly 00:00:00.000000000 (it wouldn't round "up" in that case)

ZonedDateTime.now(TZ).round("day", mode="ceil").subtract(seconds=1)

---

Other notes:

• ItemizedDelta(days=2, seconds=-1) in your example wouldn't work because it can't have a mixed sign.
• I have been considering something like a end_of(<unit>) method. Then it'd be ZonedDateTime.now(TZ).end_of("day").subtract(seconds=1)

[injust]

Ah that's much nicer!

Just wanted to point out that your examples mean the last second of today. For the last second of tomorrow, you'd need days=2:

ZonedDateTime.now(TZ).start_of_day().add(days=2, seconds=-1)

[injust]

I have been considering something like a end_of(<unit>) method.

This seems great for readability!

[injust]

Oh nice, this made it into 0.10 🚀

[injust]

Unrelated, but I wanted to mention this while I'm here: I really love the trimming pattern format! Was able to replace this:

def format_time(time: Time) -> str:
    if millis := time.nanosecond // 1_000_000:
        format = f"%I:%M:%S.{millis:03d} %p"
    elif time.second:
        format = "%I:%M:%S %p"
    else:
        format = "%I:%M %p"

    return time.py_datetime().strftime(format).removeprefix("0")

with this:

def format_time(time: Time) -> str:
    pattern = "ii:mm:ss.FFF aa" if time.second or time.nanosecond else "ii:mm aa"
    return time.format(pattern).removeprefix("0")

[ariebovenberg]

@injust good that you mention this! I'll add the patterns i (unpadded 12-hour), h (unpadded hour), as well as :SS and SS for optional seconds.

Then you should be able to oneline it: time.format("i:mm:SS.FFF aa")

[injust]

Both additions seem solid, looking forward to it. Thanks for all your great work!

[ariebovenberg]

Pre-release 0.10.0b2 is now with these changes, give it a try.

[injust]

Works like a charm!

With all the new unpadded specifiers, the "Time specifiers" table is harder to scan through now. I wonder if there's a better layout, e.g. reorganizing it into 2 tables (padded/exact/full followed by the compact variants)?