chore: Cargo fmt #1619
Annotations
38 warnings
|
stripping a prefix manually:
components/data_proxy/src/helpers.rs#L158
warning: stripping a prefix manually
--> components/data_proxy/src/helpers.rs:158:21
|
158 | let parts = path[7..].split_once('/');
| ^^^^^^^^^
|
note: the prefix was tested here
--> components/data_proxy/src/helpers.rs:157:12
|
157 | } else if path.starts_with("file://") {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
help: try using the `strip_prefix` method
|
157 ~ } else if let Some(<stripped>) = path.strip_prefix("file://") {
158 ~ let parts = <stripped>.split_once('/');
|
|
|
stripping a prefix manually:
components/data_proxy/src/helpers.rs#L151
warning: stripping a prefix manually
--> components/data_proxy/src/helpers.rs:151:21
|
151 | let parts = path[5..].split_once('/');
| ^^^^^^^^^
|
note: the prefix was tested here
--> components/data_proxy/src/helpers.rs:150:5
|
150 | if path.starts_with("s3://") {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
= note: `#[warn(clippy::manual_strip)]` on by default
help: try using the `strip_prefix` method
|
150 ~ if let Some(<stripped>) = path.strip_prefix("s3://") {
151 ~ let parts = <stripped>.split_once('/');
|
|
|
name `REPLICATIONOUT` contains a capitalized acronym:
components/data_proxy/src/config.rs#L270
warning: name `REPLICATIONOUT` contains a capitalized acronym
--> components/data_proxy/src/config.rs:270:5
|
270 | REPLICATIONOUT,
| ^^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Replicationout`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
|
|
name `REPLICATIONIN` contains a capitalized acronym:
components/data_proxy/src/config.rs#L269
warning: name `REPLICATIONIN` contains a capitalized acronym
--> components/data_proxy/src/config.rs:269:5
|
269 | REPLICATIONIN,
| ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Replicationin`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
|
|
name `BUNDLE` contains a capitalized acronym:
components/data_proxy/src/config.rs#L268
warning: name `BUNDLE` contains a capitalized acronym
--> components/data_proxy/src/config.rs:268:5
|
268 | BUNDLE,
| ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Bundle`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
|
|
name `OBJECTPACKAGE` contains a capitalized acronym:
components/data_proxy/src/config.rs#L267
warning: name `OBJECTPACKAGE` contains a capitalized acronym
--> components/data_proxy/src/config.rs:267:5
|
267 | OBJECTPACKAGE,
| ^^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Objectpackage`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
|
|
name `OBJECT` contains a capitalized acronym:
components/data_proxy/src/config.rs#L266
warning: name `OBJECT` contains a capitalized acronym
--> components/data_proxy/src/config.rs:266:5
|
266 | OBJECT,
| ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Object`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
|
|
name `ROOT` contains a capitalized acronym:
components/data_proxy/src/config.rs#L265
warning: name `ROOT` contains a capitalized acronym
--> components/data_proxy/src/config.rs:265:5
|
265 | ROOT, // Info
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Root`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
|
|
module has the same name as its containing module:
components/data_proxy/src/auth/mod.rs#L1
warning: module has the same name as its containing module
--> components/data_proxy/src/auth/mod.rs:1:1
|
1 | pub mod auth;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
|
struct update has no effect, all the fields in the struct have already been specified:
components/data_proxy/src/structs.rs#L1863
warning: struct update has no effect, all the fields in the struct have already been specified
--> components/data_proxy/src/structs.rs:1863:19
|
1863 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
|
|
struct update has no effect, all the fields in the struct have already been specified:
components/data_proxy/src/structs.rs#L1858
warning: struct update has no effect, all the fields in the struct have already been specified
--> components/data_proxy/src/structs.rs:1858:19
|
1858 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
|
|
large size difference between variants:
components/data_proxy/src/structs.rs#L1661
warning: large size difference between variants
--> components/data_proxy/src/structs.rs:1661:1
|
1661 | / pub enum ObjectsState {
1662 | | / Regular {
1663 | | | states: ResourceStates,
1664 | | | location: Option<ObjectLocation>,
1665 | | | },
| | |_____- the largest variant contains at least 1768 bytes
1666 | | / Objects {
1667 | | | root: Object,
1668 | | | filename: String,
1669 | | | },
| | |_____- the second-largest variant contains at least 424 bytes
... |
1673 | | },
1674 | | }
| |___^ the entire enum is at least 1768 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
help: consider boxing the large fields to reduce the total size of the enum
|
1663 - states: ResourceStates,
1663 + states: Box<ResourceStates>,
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
components/data_proxy/src/structs.rs#L1557
warning: very complex type used. Consider factoring parts into `type` definitions
--> components/data_proxy/src/structs.rs:1557:10
|
1557 | ) -> Result<
| __________^
1558 | | (
1559 | | NewOrExistingObject,
1560 | | NewOrExistingObject,
... |
1565 | | S3Error,
1566 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
large size difference between variants:
components/data_proxy/src/structs.rs#L1238
warning: large size difference between variants
--> components/data_proxy/src/structs.rs:1238:1
|
1238 | / pub enum ResourceState {
1239 | | / Found {
1240 | | | object: Object,
1241 | | | },
| | |_____- the largest variant contains at least 400 bytes
1242 | | / Missing {
1243 | | | name: String,
1244 | | | variant: ResourceVariant,
1245 | | | },
| | |_____- the second-largest variant contains at least 28 bytes
1246 | | #[default]
1247 | | None,
1248 | | }
| |___^ the entire enum is at least 400 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
1240 - object: Object,
1240 + object: Box<Object>,
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
components/data_proxy/src/structs.rs#L402
warning: very complex type used. Consider factoring parts into `type` definitions
--> components/data_proxy/src/structs.rs:402:10
|
402 | ) -> (
| __________^
403 | | Vec<(String, HashMap<DieselUlid, DbPermissionLevel>)>,
404 | | Vec<String>,
405 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
|
very complex type used. Consider factoring parts into `type` definitions:
components/data_proxy/src/s3_frontend/utils/ranges.rs#L22
warning: very complex type used. Consider factoring parts into `type` definitions
--> components/data_proxy/src/s3_frontend/utils/ranges.rs:22:6
|
22 | ) -> Result<(Option<String>, Option<Vec<u64>>, u64, Option<ArunaRange>)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`:
components/data_proxy/src/s3_frontend/data_handler.rs#L76
warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
--> components/data_proxy/src/s3_frontend/data_handler.rs:76:17
|
76 | // version.iter().next().map(|v| {
77 | || if let VersionVariant::IsVersion(id) = v {
78 | || object_id = *id
79 | || }
80 | || });
| ||__________________^- help: try: `if let Some(v) = version.iter().next() { ... }`
| |__________________|
|
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
|
|
called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`:
components/data_proxy/src/replication/replication_handler.rs#L521
warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
--> components/data_proxy/src/replication/replication_handler.rs:521:45
|
521 | // ... version.iter().next().map(|v| {
522 | || ... if let VersionVariant::IsVersion(id) = v {
523 | || ... current_version_id = *id
524 | || ... }
525 | || ... });
| ||________________________^- help: try: `if let Some(v) = version.iter().next() { ... }`
| |________________________|
|
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
= note: `#[warn(clippy::option_map_unit_fn)]` on by default
|
|
the `Err`-variant returned from this function is very large:
components/server/src/utils/grpc_utils.rs#L346
warning: the `Err`-variant returned from this function is very large
--> components/server/src/utils/grpc_utils.rs:346:54
|
346 | pub fn query(cache: &Arc<Cache>, id: &DieselUlid) -> Result<generic_resource::Resource, Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
components/server/src/utils/grpc_utils.rs#L329
warning: the `Err`-variant returned from this function is very large
--> components/server/src/utils/grpc_utils.rs:329:44
|
329 | pub fn get_id_and_ctx(ids: Vec<String>) -> Result<(Vec<DieselUlid>, Vec<Context>)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
components/server/src/utils/grpc_utils.rs#L35
warning: the `Err`-variant returned from this function is very large
--> components/server/src/utils/grpc_utils.rs:35:28
|
35 | fn into_inner(self) -> Result<T, Status>;
| ^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
|
|
the borrowed expression implements the required traits:
components/data_proxy/src/data_backends/s3_backend.rs#L405
warning: the borrowed expression implements the required traits
--> components/data_proxy/src/data_backends/s3_backend.rs:405:26
|
405 | .copy_source(&[source.bucket, source.key].join("/"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[source.bucket, source.key].join("/")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
the `Err`-variant returned from this function is very large:
components/server/src/middlelayer/create_request_types.rs#L151
warning: the `Err`-variant returned from this function is very large
--> components/server/src/middlelayer/create_request_types.rs:151:44
|
151 | pub fn get_relation_contexts(&self) -> Result<Vec<Context>, tonic::Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
|
|
use of a fallible conversion when an infallible one could be used:
components/server/src/middlelayer/announcements_db_handler.rs#L72
warning: use of a fallible conversion when an infallible one could be used
--> components/server/src/middlelayer/announcements_db_handler.rs:72:25
|
72 | Ok(announcement.try_into()?)
| ^^^^^^^^ help: use: `into`
|
= note: converting `Announcement` to `Announcement` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
|
this `if` has identical blocks:
components/data_proxy/src/caching/cache.rs#L579
warning: this `if` has identical blocks
--> components/data_proxy/src/caching/cache.rs:579:51
|
579 | ... if with_intermediates {
| _____________________________________________^
580 | | ... final_result.push((*id, current_path.clone()));
581 | | ... } else if x == 2 {
| |_______________________^
|
note: same as this
--> components/data_proxy/src/caching/cache.rs:581:46
|
581 | ... } else if x == 2 {
| ________________________________________^
582 | | ... final_result.push((*id, current_path.clone()));
583 | | ... }
| |_______________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
= note: `#[warn(clippy::if_same_then_else)]` on by default
|
|
the `Err`-variant returned from this function is very large:
components/server/src/grpc/notification.rs#L672
warning: the `Err`-variant returned from this function is very large
--> components/server/src/grpc/notification.rs:672:6
|
672 | ) -> Result<EventMessage, Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
|
|
the `Err`-variant returned from this function is very large:
components/server/src/grpc/notification.rs#L627
warning: the `Err`-variant returned from this function is very large
--> components/server/src/grpc/notification.rs:627:6
|
627 | ) -> Result<(Context, EventType), Status> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 176 bytes
|
= help: try reducing the size of `tonic::Status`, for example by boxing large elements or replacing it with `Box<tonic::Status>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
= note: `#[warn(clippy::result_large_err)]` on by default
|
|
doc list item overindented:
components/server/src/auth/token_handler.rs#L53
warning: doc list item overindented
--> components/server/src/auth/token_handler.rs:53:5
|
53 | /// Strongly restricts the usability of the token.
| ^^^^^^^^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
|
|
use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.:
components/server/src/middlelayer/presigned_url_handler.rs#L430
warning: use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.
--> components/server/src/middlelayer/presigned_url_handler.rs:430:60
|
430 | let config = aws_config::defaults(BehaviorVersion::v2024_03_28())
| ^^^^^^^^^^^
|
|
use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.:
components/server/src/middlelayer/finish_db_handler.rs#L52
warning: use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.
--> components/server/src/middlelayer/finish_db_handler.rs:52:60
|
52 | let config = aws_config::defaults(BehaviorVersion::v2024_03_28())
| ^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
test
`aruna_server` (lib) generated 2 warnings
|
|
test:
components/server/src/middlelayer/presigned_url_handler.rs#L430
use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.
|
|
test:
components/server/src/middlelayer/finish_db_handler.rs#L52
use of deprecated associated function `aws_config::BehaviorVersion::v2024_03_28`: Superseded by v2025_01_17, which updates the default HTTPS client stack.
|
|
test
spurious network error (3 tries remaining): [56] Failure when receiving data from the peer (OpenSSL SSL_read: SSL_ERROR_SYSCALL, errno 0)
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|